3d82d57353
Also, rename instance_id field to proper port_id. Before this change, when instance_id was passed from the Instances page in the URL, the information would be lost on form submission, and if the form contained an error, the it would be redisplayed with the port drop-down containing all ports from all instances. This also made submitting this form slow, as the drop-down would be populated with all ports on form validation. It also creates a bug, where if there are more instances than Nova's pagination allows, the ports from newer instances would no longer appear in the drop-down, and the form would fail to validate, even though the choice of port on initial form was correct. Closes-bug: #1920010 Change-Id: I3ab26c19dc9ea1ed23fcff790d0db919039099eb
183 lines
7.1 KiB
Python
183 lines
7.1 KiB
Python
# Copyright 2012 Nebula, Inc.
|
|
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
from django.urls import reverse
|
|
from django.utils.translation import ugettext_lazy as _
|
|
|
|
from neutronclient.common import exceptions as neutron_exc
|
|
|
|
from horizon import exceptions
|
|
from horizon import forms
|
|
from horizon.utils import memoized
|
|
from horizon import workflows
|
|
|
|
from openstack_dashboard import api
|
|
from openstack_dashboard import policy
|
|
from openstack_dashboard.utils import filters
|
|
|
|
ALLOCATE_URL = "horizon:project:floating_ips:allocate"
|
|
|
|
|
|
class AssociateIPAction(workflows.Action):
|
|
use_required_attribute = False
|
|
ip_id = forms.ThemableDynamicTypedChoiceField(
|
|
label=_("IP Address"),
|
|
coerce=filters.get_int_or_uuid,
|
|
empty_value=None
|
|
)
|
|
instance_id = forms.CharField(
|
|
widget=forms.widgets.HiddenInput(),
|
|
required=False,
|
|
)
|
|
port_id = forms.ThemableChoiceField(
|
|
label=_("Port to be associated")
|
|
)
|
|
|
|
class Meta(object):
|
|
name = _("IP Address")
|
|
help_text = _("Select the IP address you wish to associate with "
|
|
"the selected instance or port.")
|
|
|
|
def __init__(self, *args, **kwargs):
|
|
super().__init__(*args, **kwargs)
|
|
|
|
# If AssociateIP is invoked from instance menu, instance_id parameter
|
|
# is passed in URL. In Neutron based Floating IP implementation
|
|
# an association target is not an instance but a port, so we need
|
|
# to get an association target based on a received instance_id
|
|
# and set the initial value of instance_id ChoiceField.
|
|
q_instance_id = self.data.get('instance_id',
|
|
self.request.GET.get('instance_id'))
|
|
q_port_id = self.request.GET.get('port_id')
|
|
|
|
if policy.check((("network", "create_floatingip"),),
|
|
request=self.request):
|
|
self.fields['ip_id'].widget.add_item_link = ALLOCATE_URL
|
|
|
|
if q_instance_id:
|
|
self.initial['instance_id'] = q_instance_id
|
|
targets = self._get_target_list(q_instance_id)
|
|
# Setting the initial value here is required to avoid a situation
|
|
# where instance_id passed in the URL is used as the initial value
|
|
# unexpectedly. (This always happens if the form is invoked from
|
|
# the instance table.)
|
|
if targets:
|
|
self.initial['port_id'] = targets[0].id
|
|
else:
|
|
self.initial['port_id'] = ''
|
|
elif q_port_id:
|
|
targets = self._get_target_list()
|
|
for target in targets:
|
|
if target.port_id == q_port_id:
|
|
self.initial['port_id'] = target.id
|
|
break
|
|
|
|
def populate_ip_id_choices(self, request, context):
|
|
ips = []
|
|
redirect = reverse('horizon:project:floating_ips:index')
|
|
try:
|
|
ips = api.neutron.tenant_floating_ip_list(self.request)
|
|
except neutron_exc.ConnectionFailed:
|
|
exceptions.handle(self.request, redirect=redirect)
|
|
except Exception:
|
|
exceptions.handle(self.request,
|
|
_('Unable to retrieve floating IP addresses.'),
|
|
redirect=redirect)
|
|
options = sorted([(ip.id, ip.ip) for ip in ips if not ip.port_id])
|
|
if options:
|
|
options.insert(0, ("", _("Select an IP address")))
|
|
else:
|
|
options = [("", _("No floating IP addresses allocated"))]
|
|
|
|
return options
|
|
|
|
@memoized.memoized_method
|
|
def _get_target_list(self, instance_id=None):
|
|
targets = []
|
|
try:
|
|
if instance_id:
|
|
targets = api.neutron.floating_ip_target_list_by_instance(
|
|
self.request, instance_id)
|
|
else:
|
|
targets = api.neutron.floating_ip_target_list(self.request)
|
|
except Exception:
|
|
redirect = reverse('horizon:project:floating_ips:index')
|
|
exceptions.handle(self.request,
|
|
_('Unable to retrieve instance list.'),
|
|
redirect=redirect)
|
|
return targets
|
|
|
|
def populate_port_id_choices(self, request, context):
|
|
q_instance_id = self.data.get('instance_id',
|
|
self.initial.get('instance_id'))
|
|
# The reason of specifying an empty tuple when q_instance_id is None
|
|
# is to make memoized_method _get_target_list work. Two calls of
|
|
# _get_target_list from here and __init__ must have a same arguments.
|
|
params = (q_instance_id, ) if q_instance_id else ()
|
|
targets = self._get_target_list(*params)
|
|
instances = sorted([(target.id, target.name) for target in targets],
|
|
# Sort FIP targets by server name for easy browsing
|
|
key=lambda x: x[1])
|
|
if instances:
|
|
instances.insert(0, ("", _("Select a port")))
|
|
else:
|
|
instances = (("", _("No ports available")),)
|
|
return instances
|
|
|
|
|
|
class AssociateIP(workflows.Step):
|
|
action_class = AssociateIPAction
|
|
contributes = ("ip_id", "instance_id", "ip_address", "port_id")
|
|
|
|
def contribute(self, data, context):
|
|
context = super().contribute(data, context)
|
|
ip_id = data.get('ip_id', None)
|
|
if ip_id:
|
|
ip_choices = dict(self.action.fields['ip_id'].choices)
|
|
context["ip_address"] = ip_choices.get(ip_id, None)
|
|
return context
|
|
|
|
|
|
class IPAssociationWorkflow(workflows.Workflow):
|
|
slug = "ip_association"
|
|
name = _("Manage Floating IP Associations")
|
|
finalize_button_name = _("Associate")
|
|
success_message = _('IP address %s associated.')
|
|
failure_message = _('Unable to associate IP address %s.')
|
|
success_url = "horizon:project:floating_ips:index"
|
|
default_steps = (AssociateIP,)
|
|
|
|
def format_status_message(self, message):
|
|
if "%s" in message:
|
|
return message % self.context.get('ip_address',
|
|
_('unknown IP address'))
|
|
return message
|
|
|
|
def handle(self, request, data):
|
|
try:
|
|
api.neutron.floating_ip_associate(request,
|
|
data['ip_id'],
|
|
data['port_id'])
|
|
except neutron_exc.Conflict:
|
|
msg = _('The requested instance port is already'
|
|
' associated with another floating IP.')
|
|
exceptions.handle(request, msg)
|
|
self.failure_message = msg
|
|
return False
|
|
|
|
except Exception:
|
|
exceptions.handle(request)
|
|
return False
|
|
return True
|