8377fb9e18
Since the APIVersionManager stored the version numbers as ints and floats, it was not possible to distinguish between version 1.2 and 1.20, and also version 1.2 would be considered higher than version 1.13. With the introduction of microversioning in some services, the version numbers inflate quickly, making this a problem. This patch wraps the version numbers in a Version object, that stores the information as a semantic_version and correctly compares with other Version objects, as well as ints, floats and strings. It also removes the check for version being specified as a string, so that it's possible to specify versions such as 1.20 without having to explicitly create Version objects. Change-Id: I0b0d87582d617290f08359ad181216cb99edb768 Closes-Bug: #1649819
55 lines
2.0 KiB
Python
55 lines
2.0 KiB
Python
# Copyright 2015 IBM Corp.
|
|
# Copyright 2015, Hewlett-Packard Development Company, L.P.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
from django.conf import settings
|
|
from django.views import generic
|
|
|
|
from openstack_dashboard import api
|
|
from openstack_dashboard.api.rest import urls
|
|
from openstack_dashboard.api.rest import utils as rest_utils
|
|
|
|
|
|
# settings that we allow to be retrieved via REST API
|
|
# these settings are available to the client and are not secured.
|
|
# *** THEY SHOULD BE TREATED WITH EXTREME CAUTION ***
|
|
settings_required = getattr(settings, 'REST_API_REQUIRED_SETTINGS', [])
|
|
settings_additional = getattr(settings, 'REST_API_ADDITIONAL_SETTINGS', [])
|
|
|
|
settings_allowed = settings_required + settings_additional
|
|
|
|
|
|
@urls.register
|
|
class Settings(generic.View):
|
|
"""API for retrieving settings.
|
|
|
|
This API returns read-only settings values.
|
|
This configuration object can be fetched as needed.
|
|
Examples of settings: OPENSTACK_HYPERVISOR_FEATURES
|
|
"""
|
|
url_regex = r'settings/$'
|
|
SPECIALS = {
|
|
'HORIZON_IMAGES_UPLOAD_MODE': api.glance.get_image_upload_mode(),
|
|
'HORIZON_ACTIVE_IMAGE_VERSION': str(api.glance.VERSIONS.active),
|
|
'IMAGES_ALLOW_LOCATION': getattr(settings, 'IMAGES_ALLOW_LOCATION',
|
|
False)
|
|
}
|
|
|
|
@rest_utils.ajax()
|
|
def get(self, request):
|
|
plain_settings = {k: getattr(settings, k, None) for k
|
|
in settings_allowed if k not in self.SPECIALS}
|
|
plain_settings.update(self.SPECIALS)
|
|
return plain_settings
|