5fd5b4c893
It seems the behavior of 'partial' argument of Version class __init__ has been changed between semantic-version 2.6.0 and 2.8.1 (though I could not identify the root cause). 'partial' argument is marked as deprecated in semantic-vesion 2.7.0, so it is a good chance not to depend on 'partial' argument in horizon. This commit uses Version.coerce() [1] instead to convert non-semver version into a valid semver version. We also need to keep the original version information as it is passed when initializing python-*client (cinderclient and keystoneclient). In addition, the previous implementation based on semantic-version 2.6.0 returns True for "Version("3.55") == 3". It depends on the behavior of "partial" argument of semantic_version.Version. It was not documented and it looks tricky to depend on this behavior. "major" and "minor" properties are now introduced and api/cinder.py is updated accordingly. I believe this approach is clearer and stable. Unit test coverage on dict behavior is improved. Variable names in the unit tests are adjusted to more meaningful ones. [1] https://python-semanticversion.readthedocs.io/en/latest/#coercing-an-arbitrary-version-string Change-Id: If0deee9d0289ff91d58d942b9612f7736356ae18 |
||
---|---|---|
.. | ||
api | ||
usage | ||
utils | ||
__init__.py | ||
test_error_pages.py | ||
test_policy.py | ||
test_themes.py | ||
test_views.py |