5c4e827568
If somehow nova API service-list isn't available, listing hypervisors at /admin/hypervisors/ ends with TemplateSyntaxError. Expected result is that the page should load but user will see empty list and error message. This fix is based on idea found in other views: openstack_dashboard/dashboards/admin/... images/views.py aggregate/views.py falvors/views.pu that on any exception while getting data (get_data), we just return empty list and handle exception to display error message. Closes-Bug: #1392316 Change-Id: Ia665111185abecab6a96e6c72a6088cf2fa2e02b
37 lines
1.3 KiB
Python
37 lines
1.3 KiB
Python
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
from django.utils.translation import ugettext_lazy as _
|
|
|
|
from horizon import exceptions
|
|
from horizon import tabs
|
|
|
|
from openstack_dashboard.api import nova
|
|
from openstack_dashboard.dashboards.admin.hypervisors.compute import tables
|
|
|
|
|
|
class ComputeHostTab(tabs.TableTab):
|
|
table_classes = (tables.ComputeHostTable,)
|
|
name = _("Compute Host")
|
|
slug = "compute_host"
|
|
template_name = "horizon/common/_detail_table.html"
|
|
|
|
def get_compute_host_data(self):
|
|
try:
|
|
services = nova.service_list(self.tab_group.request)
|
|
return [service for service in services
|
|
if service.binary == 'nova-compute']
|
|
except Exception:
|
|
msg = _('Unable to get nova services list.')
|
|
exceptions.handle(self.tab_group.request, msg)
|
|
return []
|