e0e81e2b87
Currently we can't set server groups and server group members quotas in Horizon, they are still the back end definition of default. In some cases, it will failed to create an instance when server group members quota is insufficient. Therefore, it is necessary to specify the quota of the server groups and server group members when creating and editing the project. This patch allows the user to modify the default values for the server groups and the server group members quota. Change-Id: Ifbd51bec3e775d8fecbf110da37309a443a3d1ba Closes-Bug:#1732429
162 lines
6.8 KiB
Python
162 lines
6.8 KiB
Python
# Copyright 2013 Kylin, Inc.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
from django.urls import reverse
|
|
|
|
import mock
|
|
|
|
from openstack_dashboard import api
|
|
from openstack_dashboard.test import helpers as test
|
|
from openstack_dashboard.usage import quotas
|
|
|
|
INDEX_URL = reverse('horizon:admin:defaults:index')
|
|
|
|
|
|
class ServicesViewTests(test.BaseAdminViewTests):
|
|
@test.create_mocks({
|
|
api.nova: [('default_quota_get', 'nova_default_quota_get')],
|
|
api.cinder: [('default_quota_get', 'cinder_default_quota_get'),
|
|
'is_volume_service_enabled'],
|
|
api.base: ['is_service_enabled'],
|
|
api.neutron: [('default_quota_get', 'neutron_default_quota_get')],
|
|
quotas: ['enabled_quotas']})
|
|
def test_index(self):
|
|
# Neutron does not have an API for getting default system
|
|
# quotas. When not using Neutron, the floating ips quotas
|
|
# should be in the list.
|
|
self.mock_is_volume_service_enabled.return_value = True
|
|
self.mock_is_service_enabled.return_value = True
|
|
compute_quotas = [q.name for q in self.quotas.nova]
|
|
self.mock_enabled_quotas.return_value = compute_quotas
|
|
self.mock_nova_default_quota_get.return_value = self.quotas.nova
|
|
self.mock_cinder_default_quota_get.return_value = \
|
|
self.cinder_quotas.first()
|
|
self.mock_neutron_default_quota_get.return_value = \
|
|
self.neutron_quotas.first()
|
|
|
|
res = self.client.get(INDEX_URL)
|
|
|
|
self.assertTemplateUsed(res, 'admin/defaults/index.html')
|
|
|
|
expected_data = [
|
|
'<Quota: (injected_file_content_bytes, 1)>',
|
|
'<Quota: (metadata_items, 1)>',
|
|
'<Quota: (injected_files, 1)>',
|
|
'<Quota: (ram, 10000)>',
|
|
'<Quota: (instances, 10)>',
|
|
'<Quota: (cores, 10)>',
|
|
'<Quota: (key_pairs, 100)>',
|
|
'<Quota: (server_groups, 10)>',
|
|
'<Quota: (server_group_members, 10)>',
|
|
'<Quota: (injected_file_path_bytes, 255)>',
|
|
]
|
|
self._check_quotas_data(res, 'compute_quotas', expected_data)
|
|
|
|
expected_data = [
|
|
'<Quota: (gigabytes, 1000)>',
|
|
'<Quota: (snapshots, 1)>',
|
|
'<Quota: (volumes, 1)>',
|
|
]
|
|
self._check_quotas_data(res, 'volume_quotas', expected_data)
|
|
|
|
expected_data = [
|
|
'<Quota: (network, 10)>',
|
|
'<Quota: (subnet, 10)>',
|
|
'<Quota: (port, 50)>',
|
|
'<Quota: (router, 10)>',
|
|
'<Quota: (floatingip, 50)>',
|
|
'<Quota: (security_group, 20)>',
|
|
'<Quota: (security_group_rule, 100)>',
|
|
]
|
|
self._check_quotas_data(res, 'network_quotas', expected_data)
|
|
|
|
self.mock_is_volume_service_enabled.assert_called_once_with(
|
|
test.IsHttpRequest())
|
|
self.assertEqual(2, self.mock_is_service_enabled.call_count)
|
|
self.mock_is_service_enabled.assert_has_calls([
|
|
mock.call(test.IsHttpRequest(), 'compute'),
|
|
mock.call(test.IsHttpRequest(), 'network')])
|
|
self.assert_mock_multiple_calls_with_same_arguments(
|
|
self.mock_enabled_quotas, 4,
|
|
mock.call(test.IsHttpRequest()))
|
|
self.mock_nova_default_quota_get.assert_called_once_with(
|
|
test.IsHttpRequest(), self.tenant.id)
|
|
self.mock_cinder_default_quota_get.assert_called_once_with(
|
|
test.IsHttpRequest(), self.tenant.id)
|
|
self.mock_neutron_default_quota_get.assert_called_once_with(
|
|
test.IsHttpRequest())
|
|
|
|
def _check_quotas_data(self, res, slug, expected_data):
|
|
quotas_tab = res.context['tab_group'].get_tab(slug)
|
|
self.assertQuerysetEqual(quotas_tab._tables[slug].data,
|
|
expected_data,
|
|
ordered=False)
|
|
|
|
|
|
class UpdateDefaultQuotasTests(test.BaseAdminViewTests):
|
|
def _get_quota_info(self, quota):
|
|
quota_data = {}
|
|
updatable_quota_fields = (quotas.NOVA_QUOTA_FIELDS |
|
|
quotas.CINDER_QUOTA_FIELDS)
|
|
for field in updatable_quota_fields:
|
|
if field != 'fixed_ips':
|
|
limit = quota.get(field).limit or 10
|
|
quota_data[field] = int(limit)
|
|
return quota_data
|
|
|
|
@test.create_mocks({
|
|
api.nova: [('default_quota_update', 'nova_default_quota_update'),
|
|
('default_quota_get', 'nova_default_quota_get')],
|
|
api.cinder: [('default_quota_update', 'cinder_default_quota_update'),
|
|
('default_quota_get', 'cinder_default_quota_get')],
|
|
quotas: ['get_disabled_quotas']})
|
|
def test_update_default_quotas(self):
|
|
quota = self.quotas.first() + self.cinder_quotas.first()
|
|
|
|
self.mock_get_disabled_quotas.return_value = set()
|
|
self.mock_nova_default_quota_get.return_value = self.quotas.first()
|
|
self.mock_nova_default_quota_update.return_value = None
|
|
self.mock_cinder_default_quota_get.return_value = \
|
|
self.cinder_quotas.first()
|
|
self.mock_cinder_default_quota_update.return_value = None
|
|
|
|
# update some fields
|
|
quota[0].limit = 123
|
|
quota[1].limit = -1
|
|
updated_quota = self._get_quota_info(quota)
|
|
|
|
url = reverse('horizon:admin:defaults:update_defaults')
|
|
res = self.client.post(url, updated_quota)
|
|
|
|
self.assertNoFormErrors(res)
|
|
self.assertRedirectsNoFollow(res, INDEX_URL)
|
|
|
|
self.mock_get_disabled_quotas.assert_called_once_with(
|
|
test.IsHttpRequest())
|
|
|
|
nova_fields = quotas.NOVA_QUOTA_FIELDS
|
|
nova_updated_quota = dict((key, updated_quota[key]) for key in
|
|
nova_fields if key != 'fixed_ips')
|
|
self.mock_nova_default_quota_get.assert_called_once_with(
|
|
test.IsHttpRequest(), self.request.user.tenant_id)
|
|
self.mock_nova_default_quota_update.assert_called_once_with(
|
|
test.IsHttpRequest(), **nova_updated_quota)
|
|
|
|
cinder_updated_quota = dict((key, updated_quota[key]) for key in
|
|
quotas.CINDER_QUOTA_FIELDS)
|
|
self.mock_cinder_default_quota_get.assert_called_once_with(
|
|
test.IsHttpRequest(), self.request.user.tenant_id)
|
|
self.mock_cinder_default_quota_update.assert_called_once_with(
|
|
test.IsHttpRequest(), **cinder_updated_quota)
|