From a599e4d4231df2fe0cbf93e00a62171a815cee81 Mon Sep 17 00:00:00 2001 From: Dmitry Tantsur Date: Mon, 13 Nov 2017 12:27:03 +0100 Subject: [PATCH] Fix fetching ironic nodes for updating resource classes on upgrade The correct value of "limit" to fetch all nodes is 0, not -1. This issue prevents all nodes to be updated on upgrade, breaking scaling. Change-Id: I1beac8fb463a6ecfaac3dc7f176d82beba7ffdc7 Closes-Bug: #1731885 (cherry picked from commit d106dda054aab1dfd9c3c6a29efa3004beb5749e) --- instack_undercloud/undercloud.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/instack_undercloud/undercloud.py b/instack_undercloud/undercloud.py index ec7bb6a55..cfc57c984 100644 --- a/instack_undercloud/undercloud.py +++ b/instack_undercloud/undercloud.py @@ -1426,7 +1426,7 @@ def _ensure_flavor(nova, existing, name, profile=None): def _ensure_node_resource_classes(ironic): - for node in ironic.node.list(limit=-1, fields=['uuid', 'resource_class']): + for node in ironic.node.list(limit=0, fields=['uuid', 'resource_class']): if node.resource_class: if node.resource_class != DEFAULT_NODE_RESOURCE_CLASS: LOG.warning('Node %s is using a resource class %s instead '