openstack/instack-undercloud
Code Issues Proposed changes

Use uuid4 instead of uuid1 as a base for passwords

Browse Source 
uuid1 is intended to be uniq but not unpredictable. Knowing the
mac address of the host generating the uuid and what time it was
roughly generated at essentially reduces the parts of this uuid
that have to be guessed from 128 bits down to less then 48, still
a big number but there is no reason not to use the bigger of the
two.

Change-Id: If5d230a650c267247dc3a98c02a8d3021bb9eaab
This commit is contained in:
Derek Higgins 2015-05-28 07:01:30 +01:00
parent aad3455086
commit cf8efabe0c
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
instack_undercloud/undercloud.py
View File

@ -327,7 +327,7 @@ def _generate_password(length=40):
Copied from rdomanager-oscplugin. This should eventually live in
tripleo-common.
"""
uuid_str = six.text_type(uuid.uuid1()).encode("UTF-8")
uuid_str = six.text_type(uuid.uuid4()).encode("UTF-8")
return hashlib.sha1(uuid_str).hexdigest()[:length]