We need to squash to patches if we want to unblock stable/newton CI.
First patch:
Fix bashate errors and warnings (lint)
Fix 1 warning and 1 error in bash syntax:
1) E043: Arithmetic compound has inconsistent return semantics.
Fix the bash syntax to be compliant.
2) ERROR: Split export and assignments in 2 files. Ignore the files.
Fix the bash syntax to be compliant.
Note: this test has been introducted by
https://review.openstack.org/#/c/400542/
(cherry picked from commit 9031dcf620)
Second Patch:
Run `yum update -y` before Puppet run
This patch run `yum update -y` right before running os-refresh-config
(Puppet).
1) Running `yum` from an Exec in Puppet is a bad idea because Puppet has
no idea which packages resources are touched, so we're loosing the
orchestration control.
2) We need to ensure that `yum update -y` runs before any attempt to
deploy OpenStack services, so we have latest packages from RDO and
CentOS.
Closes-Bug: #1650374
(cherry picked from commit 853b4bfbad)
Change-Id: Ifbbbdbf1f0c569791abc712913c7e0f6bbe533d9
aab2dadd19