Update patch set 7
Patch Set 7: (3 comments) Thank you for keep working on this patch, Kaifeng! I couple of questions in-line. Patch-set: 7 Reviewer: Gerrit User 26340 <26340@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Verified=0
This commit is contained in:
parent
013e59e30e
commit
2173484d4c
@ -1,5 +1,74 @@
|
||||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f79a3b5_2b61fb38",
|
||||
"filename": "specs/configurable-introspection-data-backends.rst",
|
||||
"patchSetId": 7
|
||||
},
|
||||
"lineNbr": 33,
|
||||
"author": {
|
||||
"id": 26340
|
||||
},
|
||||
"writtenOn": "2018-11-22T12:46:59Z",
|
||||
"side": 1,
|
||||
"message": "How do we signal the plugin to drop its data for a node? Or will the plugin manager wipe out the `data` cell?",
|
||||
"range": {
|
||||
"startLine": 33,
|
||||
"startChar": 39,
|
||||
"endLine": 33,
|
||||
"endChar": 53
|
||||
},
|
||||
"revId": "524db1e9808a1cc61ced0fa795a8b6e71c22fc3e",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f79a3b5_2b625b16",
|
||||
"filename": "specs/configurable-introspection-data-backends.rst",
|
||||
"patchSetId": 7
|
||||
},
|
||||
"lineNbr": 72,
|
||||
"author": {
|
||||
"id": 26340
|
||||
},
|
||||
"writtenOn": "2018-11-22T12:46:59Z",
|
||||
"side": 1,
|
||||
"message": "In case of Swift, will this new column be used?\n\nWhat if some storage backend won\u0027t keep its data in ironic DB? Could some plugin choose to keep its data in some principally different DB for some reason?\n\nOn the other hand, the only sure way to wipe out stale data is to have it in ironic DB it seems....",
|
||||
"range": {
|
||||
"startLine": 72,
|
||||
"startChar": 4,
|
||||
"endLine": 72,
|
||||
"endChar": 8
|
||||
},
|
||||
"revId": "524db1e9808a1cc61ced0fa795a8b6e71c22fc3e",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f79a3b5_2b2a5be5",
|
||||
"filename": "specs/configurable-introspection-data-backends.rst",
|
||||
"patchSetId": 7
|
||||
},
|
||||
"lineNbr": 75,
|
||||
"author": {
|
||||
"id": 26340
|
||||
},
|
||||
"writtenOn": "2018-11-22T12:46:59Z",
|
||||
"side": 1,
|
||||
"message": "nit: cache sounds a bit confusing to be. Which cache? How do I know when this removal happens?\n\nIn case of Swift, does the data removal happens in-sync with node removal?",
|
||||
"range": {
|
||||
"startLine": 75,
|
||||
"startChar": 23,
|
||||
"endLine": 75,
|
||||
"endChar": 37
|
||||
},
|
||||
"revId": "524db1e9808a1cc61ced0fa795a8b6e71c22fc3e",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f79a3b5_2c9ff564",
|
||||
|
Loading…
Reference in New Issue
Block a user