Update patch set 2

Patch Set 2:

(2 comments)

Patch-set: 2
This commit is contained in:
Gerrit User 24828 2019-04-16 09:07:58 +00:00 committed by Gerrit Code Review
parent cb2310af4b
commit 6ec1519ffc
1 changed files with 48 additions and 0 deletions

View File

@ -92,6 +92,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3fce034c_80be1163",
"filename": "specs/etcd-coordination.rst",
"patchSetId": 2
},
"lineNbr": 59,
"author": {
"id": 24828
},
"writtenOn": "2019-04-16T09:07:58Z",
"side": 1,
"message": "right, the same group, so that api service will know how many conductor services there.",
"parentUuid": "3fce034c_bdf016cb",
"range": {
"startLine": 59,
"startChar": 15,
"endLine": 59,
"endChar": 45
},
"revId": "2a157e26300be615e8e81fb98774d50a27295afd",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3fce034c_3ddd0642",
@ -160,6 +184,30 @@
"revId": "2a157e26300be615e8e81fb98774d50a27295afd",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3fce034c_9302e908",
"filename": "specs/etcd-coordination.rst",
"patchSetId": 2
},
"lineNbr": 139,
"author": {
"id": 24828
},
"writtenOn": "2019-04-16T09:07:58Z",
"side": 1,
"message": "Yeah, that\u0027s the same convern I have, though it probably a light impact on deployment. As I know ubuntu 18.04 already shipped with etcd v3, we barely need to setup anything for simple cases, just install and run for a single host.\n\nWe could implement this based on database, but it seems Dmitry and Julia prefer the etcd way, I\u0027d love to have more thoughts on this.",
"parentUuid": "3fce034c_7d8f0e23",
"range": {
"startLine": 139,
"startChar": 32,
"endLine": 139,
"endChar": 71
},
"revId": "2a157e26300be615e8e81fb98774d50a27295afd",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}