From 867db8ce718eea72e7be0490abf8549413b37f90 Mon Sep 17 00:00:00 2001 From: Gerrit User 10239 <10239@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Date: Fri, 28 Apr 2017 09:21:49 +0000 Subject: [PATCH] Update patch set 2 Patch Set 2: Code-Review-1 (2 comments) Patch-set: 2 Label: Code-Review=-1 --- a9f03270ce78ea7b09c1784e21a28d2af16db8d5 | 34 ++++++++++++++++++++++++ 1 file changed, 34 insertions(+) diff --git a/a9f03270ce78ea7b09c1784e21a28d2af16db8d5 b/a9f03270ce78ea7b09c1784e21a28d2af16db8d5 index ef72b53..83c53c0 100644 --- a/a9f03270ce78ea7b09c1784e21a28d2af16db8d5 +++ b/a9f03270ce78ea7b09c1784e21a28d2af16db8d5 @@ -1,5 +1,22 @@ { "comments": [ + { + "key": { + "uuid": "5ff73747_6b481686", + "filename": "specs/multiple-pxe-filtering-backends.rst", + "patchSetId": 2 + }, + "lineNbr": 77, + "author": { + "id": 10239 + }, + "writtenOn": "2017-04-28T09:21:49Z", + "side": 1, + "message": "I\u0027d like to mirror Anton\u0027s comments that we should simplify the interface. Let\u0027s either *only* have sync() call, or have update_filter, get_blacklist and get_whitelist, but NOT sync and get_periodic_task.", + "revId": "a9f03270ce78ea7b09c1784e21a28d2af16db8d5", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, { "key": { "uuid": "5ff73747_d13f2b23", @@ -35,6 +52,23 @@ "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false }, + { + "key": { + "uuid": "5ff73747_4b61da04", + "filename": "specs/multiple-pxe-filtering-backends.rst", + "patchSetId": 2 + }, + "lineNbr": 80, + "author": { + "id": 10239 + }, + "writtenOn": "2017-04-28T09:21:49Z", + "side": 1, + "message": "so it can return None, right? worth clarifying. otherwise we don\u0027t need it.", + "revId": "a9f03270ce78ea7b09c1784e21a28d2af16db8d5", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, { "key": { "uuid": "5ff73747_b13a5f31",