From b3b6881b0ddc7d9b39b28c48522b5079dac1464d Mon Sep 17 00:00:00 2001 From: Gerrit User 18653 <18653@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Date: Tue, 2 May 2017 12:53:27 +0000 Subject: [PATCH] Update patch set 2 Patch Set 2: (3 comments) Hey guys! Thanks for your inputs! I'll post an update briefly. Cheers, milan Patch-set: 2 --- a9f03270ce78ea7b09c1784e21a28d2af16db8d5 | 54 ++++++++++++++++++++++++ 1 file changed, 54 insertions(+) diff --git a/a9f03270ce78ea7b09c1784e21a28d2af16db8d5 b/a9f03270ce78ea7b09c1784e21a28d2af16db8d5 index 83c53c0..9c79f19 100644 --- a/a9f03270ce78ea7b09c1784e21a28d2af16db8d5 +++ b/a9f03270ce78ea7b09c1784e21a28d2af16db8d5 @@ -17,6 +17,24 @@ "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false }, + { + "key": { + "uuid": "5ff73747_06494031", + "filename": "specs/multiple-pxe-filtering-backends.rst", + "patchSetId": 2 + }, + "lineNbr": 77, + "author": { + "id": 18653 + }, + "writtenOn": "2017-05-02T12:53:27Z", + "side": 1, + "message": "right, so I\u0027d update this to have the sync and get_periodic_sync_task, leaving the details of white/black list construction up to the driver implementation.", + "parentUuid": "5ff73747_6b481686", + "revId": "a9f03270ce78ea7b09c1784e21a28d2af16db8d5", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, { "key": { "uuid": "5ff73747_d13f2b23", @@ -69,6 +87,24 @@ "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false }, + { + "key": { + "uuid": "5ff73747_032372c0", + "filename": "specs/multiple-pxe-filtering-backends.rst", + "patchSetId": 2 + }, + "lineNbr": 80, + "author": { + "id": 18653 + }, + "writtenOn": "2017-05-02T12:53:27Z", + "side": 1, + "message": "to maintain the type it would have to return a periodic.periodics(enabled\u003dFalse)(lambda: None) I guess but yeah, that was my idea: for a driver to be able to opt out from periodic syncing.", + "parentUuid": "5ff73747_4b61da04", + "revId": "a9f03270ce78ea7b09c1784e21a28d2af16db8d5", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, { "key": { "uuid": "5ff73747_b13a5f31", @@ -176,6 +212,24 @@ "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false }, + { + "key": { + "uuid": "5ff73747_0696e095", + "filename": "specs/multiple-pxe-filtering-backends.rst", + "patchSetId": 2 + }, + "lineNbr": 87, + "author": { + "id": 18653 + }, + "writtenOn": "2017-05-02T12:53:27Z", + "side": 1, + "message": "\u003e Also how are you going to use `update_filter`, out of the `sync` scope?\n\nvery true, I guess there\u0027s no usage to it outside of the sync method --- I\u0027ll update the spec to reflect it (w/o get_white/black_list or update_filter)", + "parentUuid": "5ff73747_64a62e56", + "revId": "a9f03270ce78ea7b09c1784e21a28d2af16db8d5", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, { "key": { "uuid": "5ff73747_9149a3d1",