Update patch set 8
Patch Set 8: (12 comments) Hey Anton! Thanks for the update! I've got just couple of questions and nit, otherwise LGTM... Cheers, milan Patch-set: 8 Label: Verified=0
This commit is contained in:
Gerrit User 18653
Gerrit Code Review
parent
01fd134d88
commit
b74b78777b
274
e8f9c75f22777b306c4390998e2b031f847d2485
Normal file
274
e8f9c75f22777b306c4390998e2b031f847d2485
Normal file
@ -0,0 +1,274 @@
|
||||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5ff73747_4a545921",
|
||||
"filename": "specs/splitting-service-on-API-and-worker.rst",
|
||||
"patchSetId": 8
|
||||
},
|
||||
"lineNbr": 86,
|
||||
"author": {
|
||||
"id": 18653
|
||||
},
|
||||
"writtenOn": "2017-04-27T12:44:36Z",
|
||||
"side": 1,
|
||||
"message": "s/starting/processing",
|
||||
"range": {
|
||||
"startLine": 86,
|
||||
"startChar": 83,
|
||||
"endLine": 86,
|
||||
"endChar": 93
|
||||
},
|
||||
"revId": "e8f9c75f22777b306c4390998e2b031f847d2485",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5ff73747_d5248eb1",
|
||||
"filename": "specs/splitting-service-on-API-and-worker.rst",
|
||||
"patchSetId": 8
|
||||
},
|
||||
"lineNbr": 90,
|
||||
"author": {
|
||||
"id": 18653
|
||||
},
|
||||
"writtenOn": "2017-04-27T12:44:36Z",
|
||||
"side": 1,
|
||||
"message": "power off node and set `finished` state",
|
||||
"range": {
|
||||
"startLine": 90,
|
||||
"startChar": 98,
|
||||
"endLine": 90,
|
||||
"endChar": 103
|
||||
},
|
||||
"revId": "e8f9c75f22777b306c4390998e2b031f847d2485",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5ff73747_352a927e",
|
||||
"filename": "specs/splitting-service-on-API-and-worker.rst",
|
||||
"patchSetId": 8
|
||||
},
|
||||
"lineNbr": 100,
|
||||
"author": {
|
||||
"id": 18653
|
||||
},
|
||||
"writtenOn": "2017-04-27T12:44:36Z",
|
||||
"side": 1,
|
||||
"message": "and set `finished` state",
|
||||
"range": {
|
||||
"startLine": 100,
|
||||
"startChar": 85,
|
||||
"endLine": 100,
|
||||
"endChar": 90
|
||||
},
|
||||
"revId": "e8f9c75f22777b306c4390998e2b031f847d2485",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5ff73747_75481a5b",
|
||||
"filename": "specs/splitting-service-on-API-and-worker.rst",
|
||||
"patchSetId": 8
|
||||
},
|
||||
"lineNbr": 130,
|
||||
"author": {
|
||||
"id": 18653
|
||||
},
|
||||
"writtenOn": "2017-04-27T12:44:36Z",
|
||||
"side": 1,
|
||||
"message": "nit: verify,",
|
||||
"range": {
|
||||
"startLine": 130,
|
||||
"startChar": 21,
|
||||
"endLine": 130,
|
||||
"endChar": 27
|
||||
},
|
||||
"revId": "e8f9c75f22777b306c4390998e2b031f847d2485",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5ff73747_f581cafc",
|
||||
"filename": "specs/splitting-service-on-API-and-worker.rst",
|
||||
"patchSetId": 8
|
||||
},
|
||||
"lineNbr": 239,
|
||||
"author": {
|
||||
"id": 18653
|
||||
},
|
||||
"writtenOn": "2017-04-27T12:44:36Z",
|
||||
"side": 1,
|
||||
"message": "after further HA have been integrated? or see my concern below?",
|
||||
"range": {
|
||||
"startLine": 239,
|
||||
"startChar": 0,
|
||||
"endLine": 239,
|
||||
"endChar": 12
|
||||
},
|
||||
"revId": "e8f9c75f22777b306c4390998e2b031f847d2485",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5ff73747_b5058248",
|
||||
"filename": "specs/splitting-service-on-API-and-worker.rst",
|
||||
"patchSetId": 8
|
||||
},
|
||||
"lineNbr": 259,
|
||||
"author": {
|
||||
"id": 18653
|
||||
},
|
||||
"writtenOn": "2017-04-27T12:44:36Z",
|
||||
"side": 1,
|
||||
"message": "Maybe we should remove as the HA bits will be added later? Or we leave this and mention somewhere that there might be some quirks to handle while implementing such as the timeouts and glitches.",
|
||||
"range": {
|
||||
"startLine": 255,
|
||||
"startChar": 1,
|
||||
"endLine": 259,
|
||||
"endChar": 62
|
||||
},
|
||||
"revId": "e8f9c75f22777b306c4390998e2b031f847d2485",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5ff73747_958726b6",
|
||||
"filename": "specs/splitting-service-on-API-and-worker.rst",
|
||||
"patchSetId": 8
|
||||
},
|
||||
"lineNbr": 270,
|
||||
"author": {
|
||||
"id": 18653
|
||||
},
|
||||
"writtenOn": "2017-04-27T12:44:36Z",
|
||||
"side": 1,
|
||||
"message": "maybe here add the note about some special cases that one might encounter making this HA eventually?",
|
||||
"revId": "e8f9c75f22777b306c4390998e2b031f847d2485",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5ff73747_15bf96b0",
|
||||
"filename": "specs/splitting-service-on-API-and-worker.rst",
|
||||
"patchSetId": 8
|
||||
},
|
||||
"lineNbr": 274,
|
||||
"author": {
|
||||
"id": 18653
|
||||
},
|
||||
"writtenOn": "2017-04-27T12:44:36Z",
|
||||
"side": 1,
|
||||
"message": "nit: **inspector**",
|
||||
"range": {
|
||||
"startLine": 274,
|
||||
"startChar": 12,
|
||||
"endLine": 274,
|
||||
"endChar": 22
|
||||
},
|
||||
"revId": "e8f9c75f22777b306c4390998e2b031f847d2485",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5ff73747_35df320e",
|
||||
"filename": "specs/splitting-service-on-API-and-worker.rst",
|
||||
"patchSetId": 8
|
||||
},
|
||||
"lineNbr": 275,
|
||||
"author": {
|
||||
"id": 18653
|
||||
},
|
||||
"writtenOn": "2017-04-27T12:44:36Z",
|
||||
"side": 1,
|
||||
"message": "to add",
|
||||
"range": {
|
||||
"startLine": 275,
|
||||
"startChar": 0,
|
||||
"endLine": 275,
|
||||
"endChar": 2
|
||||
},
|
||||
"revId": "e8f9c75f22777b306c4390998e2b031f847d2485",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5ff73747_f5fd4a6e",
|
||||
"filename": "specs/splitting-service-on-API-and-worker.rst",
|
||||
"patchSetId": 8
|
||||
},
|
||||
"lineNbr": 279,
|
||||
"author": {
|
||||
"id": 18653
|
||||
},
|
||||
"writtenOn": "2017-04-27T12:44:36Z",
|
||||
"side": 1,
|
||||
"message": "s/third/the",
|
||||
"range": {
|
||||
"startLine": 279,
|
||||
"startChar": 50,
|
||||
"endLine": 279,
|
||||
"endChar": 56
|
||||
},
|
||||
"revId": "e8f9c75f22777b306c4390998e2b031f847d2485",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5ff73747_f50b0a7a",
|
||||
"filename": "specs/splitting-service-on-API-and-worker.rst",
|
||||
"patchSetId": 8
|
||||
},
|
||||
"lineNbr": 311,
|
||||
"author": {
|
||||
"id": 18653
|
||||
},
|
||||
"writtenOn": "2017-04-27T12:44:36Z",
|
||||
"side": 1,
|
||||
"message": "nit: with an",
|
||||
"range": {
|
||||
"startLine": 311,
|
||||
"startChar": 52,
|
||||
"endLine": 311,
|
||||
"endChar": 56
|
||||
},
|
||||
"revId": "e8f9c75f22777b306c4390998e2b031f847d2485",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5ff73747_95260615",
|
||||
"filename": "specs/splitting-service-on-API-and-worker.rst",
|
||||
"patchSetId": 8
|
||||
},
|
||||
"lineNbr": 314,
|
||||
"author": {
|
||||
"id": 18653
|
||||
},
|
||||
"writtenOn": "2017-04-27T12:44:36Z",
|
||||
"side": 1,
|
||||
"message": "mode eventually?",
|
||||
"range": {
|
||||
"startLine": 314,
|
||||
"startChar": 25,
|
||||
"endLine": 314,
|
||||
"endChar": 31
|
||||
},
|
||||
"revId": "e8f9c75f22777b306c4390998e2b031f847d2485",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
||||
Loading…
Reference in New Issue
Block a user