Update patch set 1
Patch Set 1: Code-Review-1 (11 comments) Hey Ilya! Thanks for the spec! I've got a suggestion to put the error codes declarations into a separate library, shared between the involved parties (as well as the deployer CLI automation). Cheers, milan Patch-set: 1 Label: Code-Review=-1
This commit is contained in:
Gerrit User 18653
Gerrit Code Review
parent
a9fd1acfdc
commit
c9b5fb4ae2
|
|
@ -0,0 +1,251 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7f287b81_72505e5f",
|
||||
"filename": "specs/inspector-error-enumeration.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 52,
|
||||
"author": {
|
||||
"id": 18653
|
||||
},
|
||||
"writtenOn": "2017-09-06T11:57:54Z",
|
||||
"side": 1,
|
||||
"message": "let\u0027s put the error codes \"declarations\" in a library shared between IPA, inspector and python-ironic-inspector-client.",
|
||||
"revId": "477a3c4467769bacc349a9fef7450f9abace55e6",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7f287b81_f230cea0",
|
||||
"filename": "specs/inspector-error-enumeration.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 81,
|
||||
"author": {
|
||||
"id": 18653
|
||||
},
|
||||
"writtenOn": "2017-09-06T11:57:54Z",
|
||||
"side": 1,
|
||||
"message": "please, describe the change ;) I guess using json samples is OK.",
|
||||
"range": {
|
||||
"startLine": 81,
|
||||
"startChar": 0,
|
||||
"endLine": 81,
|
||||
"endChar": 30
|
||||
},
|
||||
"revId": "477a3c4467769bacc349a9fef7450f9abace55e6",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7f287b81_321656f3",
|
||||
"filename": "specs/inspector-error-enumeration.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 87,
|
||||
"author": {
|
||||
"id": 18653
|
||||
},
|
||||
"writtenOn": "2017-09-06T11:57:54Z",
|
||||
"side": 1,
|
||||
"message": "from the top of my head, the ironic-inspector client might want to extend the intropection show \u0027command\u0027 with the new column",
|
||||
"range": {
|
||||
"startLine": 87,
|
||||
"startChar": 0,
|
||||
"endLine": 87,
|
||||
"endChar": 30
|
||||
},
|
||||
"revId": "477a3c4467769bacc349a9fef7450f9abace55e6",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7f287b81_f2be8ed2",
|
||||
"filename": "specs/inspector-error-enumeration.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 93,
|
||||
"author": {
|
||||
"id": 18653
|
||||
},
|
||||
"writtenOn": "2017-09-06T11:57:54Z",
|
||||
"side": 1,
|
||||
"message": "maybe use a common library enumerating the standardized errors for all of the involved parties in a consistent way?",
|
||||
"range": {
|
||||
"startLine": 93,
|
||||
"startChar": 0,
|
||||
"endLine": 93,
|
||||
"endChar": 30
|
||||
},
|
||||
"revId": "477a3c4467769bacc349a9fef7450f9abace55e6",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7f287b81_f2a32eb0",
|
||||
"filename": "specs/inspector-error-enumeration.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 99,
|
||||
"author": {
|
||||
"id": 18653
|
||||
},
|
||||
"writtenOn": "2017-09-06T11:57:54Z",
|
||||
"side": 1,
|
||||
"message": "not much here to expect, I\u0027d say, just that the DB (record) size is growing as well as the response by 1 key-value pair, which shouldn\u0027t be a big penalty",
|
||||
"range": {
|
||||
"startLine": 99,
|
||||
"startChar": 0,
|
||||
"endLine": 99,
|
||||
"endChar": 30
|
||||
},
|
||||
"revId": "477a3c4467769bacc349a9fef7450f9abace55e6",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7f287b81_927d0a1e",
|
||||
"filename": "specs/inspector-error-enumeration.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 111,
|
||||
"author": {
|
||||
"id": 18653
|
||||
},
|
||||
"writtenOn": "2017-09-06T11:57:54Z",
|
||||
"side": 1,
|
||||
"message": "This should read the benefits: the Deployer is able to build automation utilizing the same library as the ironic-* projects when reporting an error",
|
||||
"range": {
|
||||
"startLine": 111,
|
||||
"startChar": 0,
|
||||
"endLine": 111,
|
||||
"endChar": 30
|
||||
},
|
||||
"revId": "477a3c4467769bacc349a9fef7450f9abace55e6",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7f287b81_92a2aa99",
|
||||
"filename": "specs/inspector-error-enumeration.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 117,
|
||||
"author": {
|
||||
"id": 18653
|
||||
},
|
||||
"writtenOn": "2017-09-06T11:57:54Z",
|
||||
"side": 1,
|
||||
"message": "This should read: developers should adhere to the standardized error codes. Introducing new error code will require an update of the shared error codes library.",
|
||||
"range": {
|
||||
"startLine": 117,
|
||||
"startChar": 0,
|
||||
"endLine": 117,
|
||||
"endChar": 30
|
||||
},
|
||||
"revId": "477a3c4467769bacc349a9fef7450f9abace55e6",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7f287b81_1206ba87",
|
||||
"filename": "specs/inspector-error-enumeration.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 123,
|
||||
"author": {
|
||||
"id": 18653
|
||||
},
|
||||
"writtenOn": "2017-09-06T11:57:54Z",
|
||||
"side": 1,
|
||||
"message": "This should read: the new error_code field enhances the current error handling with further detail, expanding on the current error reporting. This should be a backwards-compatible change (older CLI (automation)) won\u0027t be broken",
|
||||
"range": {
|
||||
"startLine": 123,
|
||||
"startChar": 0,
|
||||
"endLine": 123,
|
||||
"endChar": 30
|
||||
},
|
||||
"revId": "477a3c4467769bacc349a9fef7450f9abace55e6",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7f287b81_122b5aeb",
|
||||
"filename": "specs/inspector-error-enumeration.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 139,
|
||||
"author": {
|
||||
"id": 18653
|
||||
},
|
||||
"writtenOn": "2017-09-06T11:57:54Z",
|
||||
"side": 1,
|
||||
"message": "* create the library\n* adopt the library in:\n * IPA\n * inspector\n * inspector client",
|
||||
"range": {
|
||||
"startLine": 139,
|
||||
"startChar": 0,
|
||||
"endLine": 139,
|
||||
"endChar": 30
|
||||
},
|
||||
"revId": "477a3c4467769bacc349a9fef7450f9abace55e6",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7f287b81_926cea36",
|
||||
"filename": "specs/inspector-error-enumeration.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 145,
|
||||
"author": {
|
||||
"id": 18653
|
||||
},
|
||||
"writtenOn": "2017-09-06T11:57:54Z",
|
||||
"side": 1,
|
||||
"message": "probably will require new project for the shared error-codes library",
|
||||
"range": {
|
||||
"startLine": 145,
|
||||
"startChar": 0,
|
||||
"endLine": 145,
|
||||
"endChar": 30
|
||||
},
|
||||
"revId": "477a3c4467769bacc349a9fef7450f9abace55e6",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7f287b81_321c16c0",
|
||||
"filename": "specs/inspector-error-enumeration.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 151,
|
||||
"author": {
|
||||
"id": 18653
|
||||
},
|
||||
"writtenOn": "2017-09-06T11:57:54Z",
|
||||
"side": 1,
|
||||
"message": "I guess the new library (project?) will require unittesting and integration testing the same way as e.g inspector does.",
|
||||
"range": {
|
||||
"startLine": 151,
|
||||
"startChar": 0,
|
||||
"endLine": 151,
|
||||
"endChar": 30
|
||||
},
|
||||
"revId": "477a3c4467769bacc349a9fef7450f9abace55e6",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
||||
Loading…
Reference in New Issue