openstack
/
ironic-inspector-specs
Code Issues Proposed changes
ironic-inspector-specs/503878fb7614fa2700971893a77...

299 lines
9.7 KiB
Plaintext
Raw Blame History

{
"comments": [
{
"key": {
"uuid": "7ffa3b31_ee0fddde",
"filename": "specs/splitting-service-on-API-and-conductor.rst",
"patchSetId": 4
},
"lineNbr": 39,
"author": {
"id": 18653
},
"writtenOn": "2017-04-19T09:02:52Z",
"side": 1,
"message": "nit: triggered; how about shorter syntax:\n\n starting(wait) -\u003e waiting\n processing(finish) -\u003e finished",
"range": {
"startLine": 39,
"startChar": 0,
"endLine": 39,
"endChar": 50
},
"revId": "503878fb7614fa2700971893a77cf857fbbd2604",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7ffa3b31_ee0ebd8b",
"filename": "specs/splitting-service-on-API-and-conductor.rst",
"patchSetId": 4
},
"lineNbr": 47,
"author": {
"id": 18653
},
"writtenOn": "2017-04-19T09:02:52Z",
"side": 1,
"message": "I\u0027m not sure this is correct as the pub--sub means decoupling producer and consumer, i.e the consumer may not exist hence the delivery can\u0027t be guaranteed[1]. Better maybe: \"the queue paradigm\"[2]\n\n[1] https://en.wikipedia.org/wiki/Publish%E2%80%93subscribe_pattern\n[2] https://en.wikipedia.org/wiki/Message_queue",
"range": {
"startLine": 47,
"startChar": 53,
"endLine": 47,
"endChar": 72
},
"revId": "503878fb7614fa2700971893a77cf857fbbd2604",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7ffa3b31_5c032bb9",
"filename": "specs/splitting-service-on-API-and-conductor.rst",
"patchSetId": 4
},
"lineNbr": 114,
"author": {
"id": 18653
},
"writtenOn": "2017-04-19T09:02:52Z",
"side": 1,
"message": "make this a link to support the statement; maybe to https://review.openstack.org/#/c/256342/7/specs/mitaka/at-least-once-guarantee.rst",
"range": {
"startLine": 114,
"startChar": 16,
"endLine": 114,
"endChar": 39
},
"revId": "503878fb7614fa2700971893a77cf857fbbd2604",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7ffa3b31_511d54bb",
"filename": "specs/splitting-service-on-API-and-conductor.rst",
"patchSetId": 4
},
"lineNbr": 116,
"author": {
"id": 18653
},
"writtenOn": "2017-04-19T09:02:52Z",
"side": 1,
"message": "nit: As a result, this doesn\u0027t allow to consider oslo.messaging for HA workers.",
"range": {
"startLine": 116,
"startChar": 9,
"endLine": 116,
"endChar": 56
},
"revId": "503878fb7614fa2700971893a77cf857fbbd2604",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7ffa3b31_dcea9b73",
"filename": "specs/splitting-service-on-API-and-conductor.rst",
"patchSetId": 4
},
"lineNbr": 117,
"author": {
"id": 18653
},
"writtenOn": "2017-04-19T09:02:52Z",
"side": 1,
"message": "still maybe possible to use oslo.messaging.notify with explicit timeout\u0026retry mechanisms e.g ironic-python-agent retry posting continue if the response isn\u0027t delivered in time and/or isn\u0027t 200OK[1]\n\n[1] https://github.com/openstack/ironic-inspector/blob/master/ironic_inspector/process.py#L280",
"revId": "503878fb7614fa2700971893a77cf857fbbd2604",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7ffa3b31_a2afa4e1",
"filename": "specs/splitting-service-on-API-and-conductor.rst",
"patchSetId": 4
},
"lineNbr": 126,
"author": {
"id": 18653
},
"writtenOn": "2017-04-19T09:31:58Z",
"side": 1,
"message": "Actually, the POST@/continue won\u0027t be able to return uuid anymore if this is async, not sure what to do about it, though :-/",
"range": {
"startLine": 126,
"startChar": 0,
"endLine": 126,
"endChar": 4
},
"revId": "503878fb7614fa2700971893a77cf857fbbd2604",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7ffa3b31_5d0325b9",
"filename": "specs/splitting-service-on-API-and-conductor.rst",
"patchSetId": 4
},
"lineNbr": 126,
"author": {
"id": 13636
},
"writtenOn": "2017-04-19T10:03:16Z",
"side": 1,
"message": "Why not, we are able to find node on API side and return its uuid",
"parentUuid": "7ffa3b31_a2afa4e1",
"range": {
"startLine": 126,
"startChar": 0,
"endLine": 126,
"endChar": 4
},
"revId": "503878fb7614fa2700971893a77cf857fbbd2604",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7ffa3b31_a35fa370",
"filename": "specs/splitting-service-on-API-and-conductor.rst",
"patchSetId": 4
},
"lineNbr": 126,
"author": {
"id": 18653
},
"writtenOn": "2017-04-19T12:50:06Z",
"side": 1,
"message": "yeah but that would change the POST@/v1/continue[1][2][3] endpoint still, no? If the node-lookup is OK to run synchronously and we\u0027re dropping the credentials setup, we could return the uuid immediately in the response. Otherwise we need to run the _process_node synchronously (in the API part) but I\u0027m unsure what\u0027s the point of the API/Worker splitting then.\n\nSo if we take the _process_node to worker, we need to document the API change (hence my -1) or we don\u0027t but then I\u0027m not sure we need the split at all (could just run inspector monolithic process in WSGI) \n\n[1] https://github.com/openstack/ironic-inspector/blob/master/ironic_inspector/main.py#L206\n[2] https://github.com/openstack/ironic-inspector/blob/master/ironic_inspector/process.py#L238\n[3] https://github.com/openstack/ironic-inspector/blob/master/ironic_inspector/process.py#L288",
"parentUuid": "7ffa3b31_5d0325b9",
"range": {
"startLine": 126,
"startChar": 0,
"endLine": 126,
"endChar": 4
},
"revId": "503878fb7614fa2700971893a77cf857fbbd2604",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7ffa3b31_9c3c13c9",
"filename": "specs/splitting-service-on-API-and-conductor.rst",
"patchSetId": 4
},
"lineNbr": 182,
"author": {
"id": 18653
},
"writtenOn": "2017-04-19T09:02:52Z",
"side": 1,
"message": "maybe better: to run the additional Worker service, the HTTP API round-robin service and the broker service.",
"range": {
"startLine": 182,
"startChar": 2,
"endLine": 182,
"endChar": 23
},
"revId": "503878fb7614fa2700971893a77cf857fbbd2604",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7ffa3b31_dc573b02",
"filename": "specs/splitting-service-on-API-and-conductor.rst",
"patchSetId": 4
},
"lineNbr": 183,
"author": {
"id": 18653
},
"writtenOn": "2017-04-19T09:02:52Z",
"side": 1,
"message": "maybe better: to provide both the API and Worker services with a default ...",
"range": {
"startLine": 183,
"startChar": 3,
"endLine": 183,
"endChar": 6
},
"revId": "503878fb7614fa2700971893a77cf857fbbd2604",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7ffa3b31_314d289a",
"filename": "specs/splitting-service-on-API-and-conductor.rst",
"patchSetId": 4
},
"lineNbr": 184,
"author": {
"id": 18653
},
"writtenOn": "2017-04-19T09:02:52Z",
"side": 1,
"message": "nit: with the ``in-memory`` messaging transport backend.",
"range": {
"startLine": 183,
"startChar": 55,
"endLine": 184,
"endChar": 10
},
"revId": "503878fb7614fa2700971893a77cf857fbbd2604",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7ffa3b31_5155541c",
"filename": "specs/splitting-service-on-API-and-conductor.rst",
"patchSetId": 4
},
"lineNbr": 185,
"author": {
"id": 18653
},
"writtenOn": "2017-04-19T09:02:52Z",
"side": 1,
"message": "nit: this would allow to run....without a discrete message broker.",
"range": {
"startLine": 184,
"startChar": 11,
"endLine": 185,
"endChar": 70
},
"revId": "503878fb7614fa2700971893a77cf857fbbd2604",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7ffa3b31_d1172451",
"filename": "specs/splitting-service-on-API-and-conductor.rst",
"patchSetId": 4
},
"lineNbr": 217,
"author": {
"id": 18653
},
"writtenOn": "2017-04-19T09:02:52Z",
"side": 1,
"message": "nit: with the ``in-memory`` kombu_",
"range": {
"startLine": 217,
"startChar": 51,
"endLine": 217,
"endChar": 55
},
"revId": "503878fb7614fa2700971893a77cf857fbbd2604",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}
View Git Blame Copy Permalink