ironic-inspector-specs/bcc51a458c583715dd3846479952fd8df4dc7b80
Gerrit User 13636 29ee6e52a6 Update patch set 3
Patch Set 3:

(1 comment)

Patch-set: 3
2017-04-04 07:19:46 +00:00

90 lines
3.0 KiB
Plaintext

{
"comments": [
{
"key": {
"uuid": "1a1ced50_2b116b04",
"filename": "specs/splitting-service-on-API-and-conductor.rst",
"patchSetId": 3
},
"lineNbr": 65,
"author": {
"id": 10239
},
"writtenOn": "2017-03-23T11:54:26Z",
"side": 1,
"message": "it\u0027s not that I care, but why not use oslo.messaging? that is standard for openstack, and would simplify consuming it (e.g. I would use an existing puppet module).",
"revId": "bcc51a458c583715dd3846479952fd8df4dc7b80",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ffe62b97_e65ec874",
"filename": "specs/splitting-service-on-API-and-conductor.rst",
"patchSetId": 3
},
"lineNbr": 65,
"author": {
"id": 13636
},
"writtenOn": "2017-04-04T07:19:46Z",
"side": 1,
"message": "Due the fact it wouldn\u0027t HA, https://specs.openstack.org/openstack/ironic-inspector-specs/specs/HA_inspector.html#ha-worker\n\noslo.messaging doesn\u0027t guarantee message handling, as result if workers die during message processing, it will be lost",
"parentUuid": "1a1ced50_2b116b04",
"revId": "bcc51a458c583715dd3846479952fd8df4dc7b80",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a1ced50_4bfce7b7",
"filename": "specs/splitting-service-on-API-and-conductor.rst",
"patchSetId": 3
},
"lineNbr": 112,
"author": {
"id": 10239
},
"writtenOn": "2017-03-23T11:54:26Z",
"side": 1,
"message": "usually alternatives involve listing pros/cons of alternative approaches..",
"revId": "bcc51a458c583715dd3846479952fd8df4dc7b80",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a1ced50_6bf7e3d2",
"filename": "specs/splitting-service-on-API-and-conductor.rst",
"patchSetId": 3
},
"lineNbr": 156,
"author": {
"id": 10239
},
"writtenOn": "2017-03-23T11:54:26Z",
"side": 1,
"message": "Yes, this has to be done, and it has to also default to the in-memory oslo.msg driver",
"revId": "bcc51a458c583715dd3846479952fd8df4dc7b80",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a1ced50_8b025fb2",
"filename": "specs/splitting-service-on-API-and-conductor.rst",
"patchSetId": 3
},
"lineNbr": 159,
"author": {
"id": 10239
},
"writtenOn": "2017-03-23T11:54:26Z",
"side": 1,
"message": "Do I get it right that we don\u0027t support multiple workers on the same host because of firewall? May be worth spelling out.",
"revId": "bcc51a458c583715dd3846479952fd8df4dc7b80",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}