openstack/ironic-inspector-specs
Code Issues Proposed changes
bac04a4d14
ironic-inspector-specs/2a157e26300be615e8e81fb98774d50a27295afd
Gerrit User 24828 11e3637022 Update patch set 2 
Patch-set: 2
2019-05-08 06:49:19 +00:00

429 lines
13 KiB
Plaintext
Raw Blame History

{
"comments": [
{
"key": {
"uuid": "3fce034c_7d84ee5e",
"filename": "specs/etcd-coordination.rst",
"patchSetId": 2
},
"lineNbr": 26,
"author": {
"id": 23851
},
"writtenOn": "2019-04-16T08:17:48Z",
"side": 1,
"message": "nit: maybe rewrite this as there\u0027s a repetition between beginning and end of the phrase",
"range": {
"startLine": 24,
"startChar": 0,
"endLine": 26,
"endChar": 11
},
"revId": "2a157e26300be615e8e81fb98774d50a27295afd",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3fce034c_bdc9f678",
"filename": "specs/etcd-coordination.rst",
"patchSetId": 2
},
"lineNbr": 40,
"author": {
"id": 23851
},
"writtenOn": "2019-04-16T08:17:48Z",
"side": 1,
"message": "would add a short introduction sentence about etcd",
"range": {
"startLine": 40,
"startChar": 3,
"endLine": 40,
"endChar": 7
},
"revId": "2a157e26300be615e8e81fb98774d50a27295afd",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "dfbec78f_df2e36f9",
"filename": "specs/etcd-coordination.rst",
"patchSetId": 2
},
"lineNbr": 40,
"author": {
"id": 24828
},
"writtenOn": "2019-05-08T06:49:19Z",
"side": 1,
"message": "Done",
"parentUuid": "3fce034c_bdc9f678",
"range": {
"startLine": 40,
"startChar": 3,
"endLine": 40,
"endChar": 7
},
"revId": "2a157e26300be615e8e81fb98774d50a27295afd",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3fce034c_bd6d7699",
"filename": "specs/etcd-coordination.rst",
"patchSetId": 2
},
"lineNbr": 53,
"author": {
"id": 23851
},
"writtenOn": "2019-04-16T08:17:48Z",
"side": 1,
"message": "nit: remove one \"query\" word",
"range": {
"startLine": 53,
"startChar": 3,
"endLine": 53,
"endChar": 14
},
"revId": "2a157e26300be615e8e81fb98774d50a27295afd",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "dfbec78f_1fc12e2f",
"filename": "specs/etcd-coordination.rst",
"patchSetId": 2
},
"lineNbr": 53,
"author": {
"id": 24828
},
"writtenOn": "2019-05-08T06:49:19Z",
"side": 1,
"message": "Done",
"parentUuid": "3fce034c_bd6d7699",
"range": {
"startLine": 53,
"startChar": 3,
"endLine": 53,
"endChar": 14
},
"revId": "2a157e26300be615e8e81fb98774d50a27295afd",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3fce034c_bdf016cb",
"filename": "specs/etcd-coordination.rst",
"patchSetId": 2
},
"lineNbr": 59,
"author": {
"id": 23851
},
"writtenOn": "2019-04-16T08:17:48Z",
"side": 1,
"message": "same group as API ?",
"range": {
"startLine": 59,
"startChar": 15,
"endLine": 59,
"endChar": 45
},
"revId": "2a157e26300be615e8e81fb98774d50a27295afd",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3fce034c_80be1163",
"filename": "specs/etcd-coordination.rst",
"patchSetId": 2
},
"lineNbr": 59,
"author": {
"id": 24828
},
"writtenOn": "2019-04-16T09:07:58Z",
"side": 1,
"message": "right, the same group, so that api service will know how many conductor services there.",
"parentUuid": "3fce034c_bdf016cb",
"range": {
"startLine": 59,
"startChar": 15,
"endLine": 59,
"endChar": 45
},
"revId": "2a157e26300be615e8e81fb98774d50a27295afd",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3fce034c_3ddd0642",
"filename": "specs/etcd-coordination.rst",
"patchSetId": 2
},
"lineNbr": 70,
"author": {
"id": 23851
},
"writtenOn": "2019-04-16T08:17:48Z",
"side": 1,
"message": "nit: remove one \"the\" word",
"range": {
"startLine": 70,
"startChar": 52,
"endLine": 70,
"endChar": 59
},
"revId": "2a157e26300be615e8e81fb98774d50a27295afd",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "dfbec78f_5fc7a646",
"filename": "specs/etcd-coordination.rst",
"patchSetId": 2
},
"lineNbr": 70,
"author": {
"id": 24828
},
"writtenOn": "2019-05-08T06:49:19Z",
"side": 1,
"message": "Done",
"parentUuid": "3fce034c_3ddd0642",
"range": {
"startLine": 70,
"startChar": 52,
"endLine": 70,
"endChar": 59
},
"revId": "2a157e26300be615e8e81fb98774d50a27295afd",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3fce034c_9da43abb",
"filename": "specs/etcd-coordination.rst",
"patchSetId": 2
},
"lineNbr": 114,
"author": {
"id": 23851
},
"writtenOn": "2019-04-16T08:17:48Z",
"side": 1,
"message": "s/options below/the following options",
"range": {
"startLine": 114,
"startChar": 42,
"endLine": 114,
"endChar": 55
},
"revId": "2a157e26300be615e8e81fb98774d50a27295afd",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "dfbec78f_3fcc3269",
"filename": "specs/etcd-coordination.rst",
"patchSetId": 2
},
"lineNbr": 114,
"author": {
"id": 24828
},
"writtenOn": "2019-05-08T06:49:19Z",
"side": 1,
"message": "Done",
"parentUuid": "3fce034c_9da43abb",
"range": {
"startLine": 114,
"startChar": 42,
"endLine": 114,
"endChar": 55
},
"revId": "2a157e26300be615e8e81fb98774d50a27295afd",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3fce034c_7d8f0e23",
"filename": "specs/etcd-coordination.rst",
"patchSetId": 2
},
"lineNbr": 139,
"author": {
"id": 23851
},
"writtenOn": "2019-04-16T08:17:48Z",
"side": 1,
"message": "The idea in general is great, I\u0027m just not sure forcing etcd as mandatory requirement to deploy inspector is; do you think it would be possible to make this optional ?",
"range": {
"startLine": 139,
"startChar": 32,
"endLine": 139,
"endChar": 71
},
"revId": "2a157e26300be615e8e81fb98774d50a27295afd",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3fce034c_9302e908",
"filename": "specs/etcd-coordination.rst",
"patchSetId": 2
},
"lineNbr": 139,
"author": {
"id": 24828
},
"writtenOn": "2019-04-16T09:07:58Z",
"side": 1,
"message": "Yeah, that\u0027s the same convern I have, though it probably a light impact on deployment. As I know ubuntu 18.04 already shipped with etcd v3, we barely need to setup anything for simple cases, just install and run for a single host.\n\nWe could implement this based on database, but it seems Dmitry and Julia prefer the etcd way, I\u0027d love to have more thoughts on this.",
"parentUuid": "3fce034c_7d8f0e23",
"range": {
"startLine": 139,
"startChar": 32,
"endLine": 139,
"endChar": 71
},
"revId": "2a157e26300be615e8e81fb98774d50a27295afd",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3fce034c_b354c5cb",
"filename": "specs/etcd-coordination.rst",
"patchSetId": 2
},
"lineNbr": 139,
"author": {
"id": 10239
},
"writtenOn": "2019-04-16T09:22:19Z",
"side": 1,
"message": "etcd is a part of the openstack base services: https://governance.openstack.org/tc/reference/base-services.html#current-list-of-base-services. requiring it should not be a big surprise. we could do it through database, but if you look at the ironic implementation, you\u0027ll see that we invent a lot of things that go for free with etcd.",
"parentUuid": "3fce034c_9302e908",
"range": {
"startLine": 139,
"startChar": 32,
"endLine": 139,
"endChar": 71
},
"revId": "2a157e26300be615e8e81fb98774d50a27295afd",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3fce034c_f3732d7f",
"filename": "specs/etcd-coordination.rst",
"patchSetId": 2
},
"lineNbr": 139,
"author": {
"id": 10239
},
"writtenOn": "2019-04-16T09:23:40Z",
"side": 1,
"message": "another thought: we can keep single-process ironic-inspector working instead of deprecating it as a part of the HA work. this will serve the simplest case. and we can make etcd mandatory when rabbitmq is not used. it will require more code, but will provide an alternative.",
"parentUuid": "3fce034c_b354c5cb",
"range": {
"startLine": 139,
"startChar": 32,
"endLine": 139,
"endChar": 71
},
"revId": "2a157e26300be615e8e81fb98774d50a27295afd",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3fce034c_5a2a3f90",
"filename": "specs/etcd-coordination.rst",
"patchSetId": 2
},
"lineNbr": 139,
"author": {
"id": 24828
},
"writtenOn": "2019-04-17T06:05:06Z",
"side": 1,
"message": "I am thinking some option like [DEFAULT]standalone (boolean)\n\nwe will have three console scripts after the split:\n\n* ironic-inspector: runs at standalone\u003dTrue, stop otherwise. No etcd dependency.\n* ironic-inspector-api, ironic-inspector-conductor: runs at standalone\u003dFalse, stop otherwise. Requires etcd.\n\nwe can still keep rabbitmq as an alternative for messaging, use [DEFAULT]rpc_backend to control rpc backend, rabbit, json-rpc, etc.\n\nSounds a reverse process of single process ironic heh :)\n\nWe can drop the standalone one at suitable time.",
"parentUuid": "3fce034c_f3732d7f",
"range": {
"startLine": 139,
"startChar": 32,
"endLine": 139,
"endChar": 71
},
"revId": "2a157e26300be615e8e81fb98774d50a27295afd",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3fce034c_fa052bc3",
"filename": "specs/etcd-coordination.rst",
"patchSetId": 2
},
"lineNbr": 139,
"author": {
"id": 24828
},
"writtenOn": "2019-04-17T06:05:06Z",
"side": 1,
"message": "yup, but it doesn\u0027t say etcd v3 is the minimum version, but we will need etcd3 for the group management feature.\n\ncoreos said \"etcd v2 will no longer be shipped with Container Linux after June 2018.\" It may need some time for the shift.\n\nI don\u0027t know the plan of other linux distributions, but bionic seems ok, this means we have an upstream environment for the implementation, while doesn\u0027t impact existing deployment as long as the etcd implementation is optional.",
"parentUuid": "3fce034c_b354c5cb",
"range": {
"startLine": 139,
"startChar": 32,
"endLine": 139,
"endChar": 71
},
"revId": "2a157e26300be615e8e81fb98774d50a27295afd",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3fce034c_bd168448",
"filename": "specs/etcd-coordination.rst",
"patchSetId": 2
},
"lineNbr": 139,
"author": {
"id": 23851
},
"writtenOn": "2019-04-19T08:51:14Z",
"side": 1,
"message": "Thanks Kaifeng and Dmitry for the replies!\nCentOS and Fedora also provide etcd v3 by default, so I wouldn\u0027t worry too much about that.\nAgain, I really like the idea and I\u0027m all for it, definitely etcd \u003e database!\nI know it\u0027s more work, but if I we could keep an alternative at least for a while and then dropping the standalone at some point, would be great.\nThe option alternative sounds good to me :)",
"parentUuid": "3fce034c_fa052bc3",
"range": {
"startLine": 139,
"startChar": 32,
"endLine": 139,
"endChar": 71
},
"revId": "2a157e26300be615e8e81fb98774d50a27295afd",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}
View Git Blame Copy Permalink