openstack
/
ironic-inspector
Code Issues Proposed changes

Merge "Combine multiple warning logs into one in create_ports"

This commit is contained in:
Jenkins 2016-08-04 08:24:31 +00:00 committed by Gerrit Code Review
parent c3f38feb2e 7a2e1a248a
commit 0a4bb4d437
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
ironic_inspector/node_cache.py
View File

@ -227,12 +227,15 @@ class NodeInfo(object):
A warning is issued if port already exists on a node.
"""
existing_macs = []
for mac in macs:
if mac not in self.ports():
self._create_port(mac)
else:
LOG.warning(_LW('Port %s already exists, skipping'),
mac, node_info=self)
existing_macs.append(mac)
if existing_macs:
LOG.warning(_LW('Did not create ports %s as they already exist'),
existing_macs, node_info=self)
def ports(self):
"""Get Ironic port objects associated with the cached node record.