openstack
/
ironic-inspector
Code Issues Proposed changes

Trivial: improve logging in FSM transition 

Logging function name and module where it is located
if exception is raised during fsm transition.
It helps to find out the cause faster.

Change-Id: I2b07333420a53b7c83ea4fd99332b5e444bfc8c1
This commit is contained in:
Anton Arefiev 2017-02-02 13:07:22 +02:00
parent 0b634ed5b3
commit 25015daded
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
ironic_inspector/node_cache.py
View File

@ -26,6 +26,7 @@ from oslo_config import cfg
from oslo_db import exception as db_exc
from oslo_db.sqlalchemy import utils as db_utils
from oslo_utils import excutils
from oslo_utils import reflection
from oslo_utils import timeutils
from oslo_utils import uuidutils
from sqlalchemy.orm import exc as orm_errors
@ -523,14 +524,16 @@ def triggers_fsm_error_transition(errors=(Exception,),
except no_errors as exc:
LOG.debug('Not processing error event for the '
'exception: %(exc)s raised by %(func)s',
{'exc': exc, 'func': func}, node_info=node_info)
{'exc': exc,
'func': reflection.get_callable_name(func)},
node_info=node_info)
except errors as exc:
with excutils.save_and_reraise_exception():
LOG.error(_LE('Processing the error event because of an '
'exception %(exc_type)s: %(exc)s raised by '
'%(func)s'),
{'exc_type': type(exc), 'exc': exc,
'func': func},
'func': reflection.get_callable_name(func)},
node_info=node_info)
# an error event should be possible from all states
node_info.fsm_event(istate.Events.error)