From 375661ee23e06335ee55833ff33fc8c2218f184f Mon Sep 17 00:00:00 2001 From: Luong Anh Tuan Date: Wed, 31 Aug 2016 18:43:24 +0700 Subject: [PATCH] Change asserts with more specific assert methods. This patch replaces assertTrue(isinstance(a, b)) by native assert function assertIsInstance/assertNotIsInstance. Change-Id: Ia3e34167a1c454fde1b28079c1742b99e1d40ff1 --- ironic_inspector/test/unit/test_migrations.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/ironic_inspector/test/unit/test_migrations.py b/ironic_inspector/test/unit/test_migrations.py index b09a11152..b6fb759d6 100644 --- a/ironic_inspector/test/unit/test_migrations.py +++ b/ironic_inspector/test/unit/test_migrations.py @@ -265,10 +265,9 @@ class MigrationCheckersMixin(object): self.assertIsInstance(rules.c.description.type, sqlalchemy.types.Text) self.assertIn('disabled', col_names) # in some backends bool type is integer - self.assertTrue(isinstance(rules.c.disabled.type, - sqlalchemy.types.Boolean) or - isinstance(rules.c.disabled.type, - sqlalchemy.types.Integer)) + self.assertIsInstance(rules.c.disabled.type, + (sqlalchemy.types.Boolean, + sqlalchemy.types.Integer)) conditions = db_utils.get_table(engine, 'rule_conditions') col_names = [column.name for column in conditions.c]