openstack/ironic-inspector
Code Issues Proposed changes

BasePhysnetHook - Follow up

Browse Source 
- Removes confusing comment in _get_physnet_patch method.
- Move binary operator to follow code style.
- Removed info log entry in before_update.
- Move releasenote to 'other' section as this is no user
  faceing change.

Change-Id: I53d8bf97a87ae365a085a795901eaed1f0c32d9b
This commit is contained in:
Harald Jensås 2020-04-22 10:39:34 +02:00
parent 436fd8ad99
commit 43de977994
2 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
ironic_inspector/plugins/base_physnet.py
View File

@ -53,9 +53,8 @@ class BasePhysnetHook(base.ProcessingHook):
:param port: The ironic port to patch. :param port: The ironic port to patch.
:returns: A dict to be used as a patch for the port, or None. :returns: A dict to be used as a patch for the port, or None.
""" """
# Bug is here. if (not CONF.processing.overwrite_existing
if (not CONF.processing.overwrite_existing or or port.physical_network == physnet):
port.physical_network == physnet):
return return
return {'op': 'add', 'path': '/physical_network', 'value': physnet} return {'op': 'add', 'path': '/physical_network', 'value': physnet}
@ -63,8 +62,6 @@ class BasePhysnetHook(base.ProcessingHook):
"""Process introspection data and patch port physical network.""" """Process introspection data and patch port physical network."""
inventory = utils.get_inventory(introspection_data) inventory = utils.get_inventory(introspection_data)
LOG.info("Plugin: %s", type(self))
ironic_ports = node_info.ports() ironic_ports = node_info.ports()
for iface in inventory['interfaces']: for iface in inventory['interfaces']:

2
releasenotes/notes/physnet-base-4499ad3a7c08725f.yaml
View File

@ -1,4 +1,4 @@
--- ---
features: other:
- Added base class (``BasePhysnetHook``) for plugins that assign a physical - Added base class (``BasePhysnetHook``) for plugins that assign a physical
network to ports. network to ports.