openstack/ironic-inspector
Code Issues Proposed changes

Deprecates [processing]store_data_location

Browse Source 
Since the introspection data could be retrieved from inspector API,
there is no need to keep an extra link in ironic. This also keeps
inspector's behavior consistent by doing so.

Change-Id: Ib667afc4f16551b195641888831df7b681217184
Story: 1726713
Task: 11373
This commit is contained in:
Kaifeng Wang 2019-02-26 11:49:15 +08:00
parent 68a4829c01
commit 444c20d9fc
3 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
ironic_inspector/conf/processing.py
View File

@ -80,7 +80,11 @@ _OPTS = [
'not be stored.')),
cfg.StrOpt('store_data_location',
help=_('Name of the key to store the location of stored data '
'in the extra column of the Ironic database.')),
'in the extra column of the Ironic database.'),
deprecated_for_removal=True,
deprecated_reason=_('The introspection data could be retrieved '
'from inspector API, there is no need to '
'keep an extra link in ironic.')),
cfg.BoolOpt('disk_partitioning_spacing',
default=True,
help=_('Whether to leave 1 GiB of disk size untouched for '

4
ironic_inspector/plugins/introspection_data.py
View File

@ -95,9 +95,11 @@ class SwiftStore(object):
LOG.info('Introspection data was stored for node %(node)s in Swift '
'object %(obj_name)s', {'node': node_uuid,
'obj_name': swift_object_name})
# TODO(kaifeng) Remove the deprecated store_data_location at Train
# cycle.
if CONF.processing.store_data_location:
node_info = node_cache.get_node(node_uuid)
# TODO(kaifeng) node_info is not synced back, while we are not
# NOTE(kaifeng) node_info is not synced back, while we are not
# using extra in the processing logic, it looks fine at the moment,
# but we should consider refactor in a later time.
node_info.patch([{'op': 'add', 'path': '/extra/%s' %

6
releasenotes/notes/deprecate-store-data-location-037eaab9cd326646.yaml Normal file
View File

@ -0,0 +1,6 @@
---
deprecations:
- |
Deprecated the configuration option ``[processing]store_data_location``.
The introspection data could be retrieved from inspector, there is no
need to keep an extra link in ironic.