openstack/ironic-inspector
Code Issues Proposed changes

Fix valid provision states for introspection

Browse Source 
Ironic provision state 'inspectfail' was renamed to 'inspect failed',
but Inspector continues to rely on old name when performing node
provision state validation.

Change-Id: I21763261bfe2015f9ea8984eef62c5b5cb513d2b
Closes-Bug: #1668326
This commit is contained in:
Anton Arefiev 2017-02-27 18:31:28 +02:00
parent 66386efd5f
commit 490cad0b04
2 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ironic_inspector/common/ironic.py
View File

@ -26,7 +26,7 @@ CONF = cfg.CONF
LOG = utils.getProcessingLogger(__name__) LOG = utils.getProcessingLogger(__name__)
# See http://specs.openstack.org/openstack/ironic-specs/specs/kilo/new-ironic-state-machine.html # noqa # See http://specs.openstack.org/openstack/ironic-specs/specs/kilo/new-ironic-state-machine.html # noqa
VALID_STATES = {'enroll', 'manageable', 'inspecting', 'inspectfail'} VALID_STATES = {'enroll', 'manageable', 'inspecting', 'inspect failed'}
SET_CREDENTIALS_VALID_STATES = {'enroll'} SET_CREDENTIALS_VALID_STATES = {'enroll'}
# 1.11 is API version, which support 'enroll' state # 1.11 is API version, which support 'enroll' state

11
releasenotes/notes/fix-wrong-provision-state-name-150c91c48d471bf9.yaml Normal file
View File

@ -0,0 +1,11 @@
---
fixes:
- |
Wrong provision state name 'inspectfail' in *ironic-inspector* valid
states for node inspection.
This issue leads to state inconsistency between *ironic* and
*ironic-inspector*. For example, if *ironic* inspection timeout is
lower than *ironic-inspector*'s, and inspection timeout occurs, *ironic*
will transition node into 'inspect failed' provision state. In such case
when node inspection finishes without errors the node will be in
'inspect failed' provision state with inspection in 'finished' state.