From 51e791e9548dfa470b3e774251a1a38af1b0c20c Mon Sep 17 00:00:00 2001 From: Madhuri Kumari Date: Tue, 24 Dec 2019 13:01:43 +0530 Subject: [PATCH] Add librsvg2* to bindep and bindep env 76cbd2dbbb131224e73a4b7c4019c378d2bbaf20 added the docs build requirement on sphinxcontrib-svg2pdfconverter which needs the native rsvg-convert command. This change adds the native package that provides that command to bindep.txt. Also adds bindep env in tox.ini. Change-Id: I72aa8695c058989b4a1aa62cbb5d5fda2ce348ad --- bindep.txt | 4 ++++ tox.ini | 10 ++++++++++ 2 files changed, 14 insertions(+) diff --git a/bindep.txt b/bindep.txt index 692c51a7a..67c198bb7 100644 --- a/bindep.txt +++ b/bindep.txt @@ -4,3 +4,7 @@ mysql-server [platform:dpkg] # needed for psql postgresql postgresql-client [platform:dpkg] + +# libsrvg2 is needed for sphinxcontrib-svg2pdfconverter in docs builds. +librsvg2-tools [doc platform:rpm] +librsvg2-bin [doc platform:dpkg] diff --git a/tox.ini b/tox.ini index 5c0662508..dabc6b7f4 100644 --- a/tox.ini +++ b/tox.ini @@ -100,3 +100,13 @@ deps = deps = -r{toxinidir}/test-requirements.txt commands = bandit -r ironic_inspector -x test -n 5 -ll -c tools/bandit.yml +# This environment can be used to quickly validate that all needed system +# packages required to successfully execute test targets are installed +[testenv:bindep] +# Do not install any requirements. We want this to be fast and work even if +# system dependencies are missing, since it's used to tell you what system +# dependencies are missing! This also means that bindep must be installed +# separately, outside of the requirements files. +deps = bindep +commands = bindep test +