openstack
/
ironic-inspector
Code Issues Proposed changes

Provide meaningful error messages in functional tests 

The default python-requests error message does not contain response body,
so it's not possible to figure out the actual cause of the failure.
Change it to a custom exception including the cause.

Change-Id: I83ea035ab2b3ace4dbdf5b17cd5d632c4c704003
This commit is contained in:
Dmitry Tantsur 2016-08-02 12:20:47 +02:00
parent 823f6d26a2
commit 52922bc2f0
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
ironic_inspector/test/functional.py
View File

@ -69,6 +69,10 @@ def get_test_conf_file():
return TEST_CONF_FILE
def get_error(response):
return response.json()['error']['message']
class Base(base.NodeTest):
ROOT_URL = 'http://127.0.0.1:5050'
IS_FUNCTIONAL = True
@ -115,7 +119,11 @@ class Base(base.NodeTest):
if expect_error:
self.assertEqual(expect_error, res.status_code)
else:
res.raise_for_status()
if res.status_code >= 400:
msg = ('%(meth)s %(url)s failed with code %(code)s: %(msg)s' %
{'meth': method.upper(), 'url': endpoint,
'code': res.status_code, 'msg': get_error(res)})
raise AssertionError(msg)
return res
def call_introspect(self, uuid, new_ipmi_username=None,