From f416673374ac28ab116c0e82bda9986bc9586829 Mon Sep 17 00:00:00 2001
From: Iury Gregory Melo Ferreira <imelofer@redhat.com>
Date: Thu, 7 May 2020 15:16:05 +0200
Subject: [PATCH] Merge jobs

- Removed ironic-inspector-non-standalone-tempest
- add the non-standalone case to ironic-inspector-tempest-managed and
  make voting in check and gate.
- Renamed ironic-inspector-tempest-managed to match the new scenario.
- Keep a copy of ironic-inspector-tempest-managed

Change-Id: Icf9406c2b9e2829a36fa37e49b2692a76d67bdb6
---
 zuul.d/ironic-inspector-jobs.yaml | 21 +++++++++------------
 zuul.d/project.yaml               |  8 ++------
 2 files changed, 11 insertions(+), 18 deletions(-)

diff --git a/zuul.d/ironic-inspector-jobs.yaml b/zuul.d/ironic-inspector-jobs.yaml
index 9f83c6b0a..11316df5e 100644
--- a/zuul.d/ironic-inspector-jobs.yaml
+++ b/zuul.d/ironic-inspector-jobs.yaml
@@ -46,8 +46,8 @@
         ironic-inspector-dhcp: True
 
 - job:
-    name: ironic-inspector-non-standalone-tempest
-    description: Execute python3 tempest tests for ironic-inspector running in non-standalone mode
+    name: ironic-inspector-tempest-managed-non-standalone
+    description: The boot is managed by ironic, ironic-inspector runs in non-standalone mode.
     parent: ironic-inspector-base
     vars:
       tempest_test_timeout: 3600
@@ -56,6 +56,9 @@
         IRONIC_DEFAULT_BOOT_OPTION: netboot
         IRONIC_INSPECTOR_STANDALONE: False
         IRONIC_TEMPEST_BUILD_TIMEOUT: 3600
+        IRONIC_INSPECTOR_TEMPEST_DISCOVERY_TIMEOUT: 1200
+        IRONIC_INSPECTOR_MANAGED_BOOT: True
+        IRONIC_INSPECTOR_NODE_NOT_FOUND_HOOK: ''
       devstack_services:
         s-account: True
         s-container: True
@@ -81,16 +84,6 @@
         IRONIC_INSPECTOR_DHCP_FILTER: dnsmasq
         IRONIC_INSPECTOR_INTROSPECTION_DATA_STORE: database
 
-- job:
-    name: ironic-inspector-tempest-managed
-    description: A job with boot managed by ironic
-    parent: ironic-inspector-base
-    vars:
-      devstack_localrc:
-        IRONIC_DEFAULT_BOOT_OPTION: netboot
-        IRONIC_INSPECTOR_MANAGED_BOOT: True
-        IRONIC_INSPECTOR_NODE_NOT_FOUND_HOOK: ''
-
 - job:
     # Security testing for known issues
     name: ironic-inspector-tox-bandit
@@ -186,3 +179,7 @@
       - ^setup.cfg$
       - ^tools/.*$
       - ^tox.ini$
+
+- job:
+    name: ironic-inspector-tempest-managed
+    parent: ironic-inspector-tempest-managed-non-standalone
diff --git a/zuul.d/project.yaml b/zuul.d/project.yaml
index 92271be88..8894b5b28 100644
--- a/zuul.d/project.yaml
+++ b/zuul.d/project.yaml
@@ -11,11 +11,7 @@
         - ironic-inspector-grenade
         - ironic-inspector-tempest
         - ironic-inspector-tempest-discovery
-        - ironic-inspector-tempest-managed
-        # NOTE (rpittau) sadly temporary disabling the non-standalone-tempest
-        # job until we got it fixed
-        - ironic-inspector-non-standalone-tempest:
-            voting: false
+        - ironic-inspector-tempest-managed-non-standalone
         - openstack-tox-functional-py36
         - bifrost-integration-tinyipa-ubuntu-bionic:
             voting: false
@@ -27,5 +23,5 @@
         - ironic-inspector-grenade
         - ironic-inspector-tempest
         - ironic-inspector-tempest-discovery
-        - ironic-inspector-tempest-managed
+        - ironic-inspector-tempest-managed-non-standalone
         - openstack-tox-functional-py36