openstack/ironic-inspector
Code Issues Proposed changes

Remove PXE filter logging

Browse Source 
Remove log messages which tend to fill up the inspector logs when
debug is enabled without providing much value.

Change-Id: Ib848a13f30f5ef0074c9e43eb0a414bec0254637
This commit is contained in:
Bob Fournier 2019-03-14 21:08:31 -04:00
parent 0d5bc4b99d
commit 9978579fc1
3 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
ironic_inspector/pxe_filter/base.py
View File

@ -133,8 +133,6 @@ class BaseFilter(interface.FilterDriver):
:raises: InvalidFilterDriverState :raises: InvalidFilterDriverState
:returns: nothing. :returns: nothing.
""" """
LOG.debug('The PXE filter driver %s enters the fsm_reset_on_error '
'context', self)
try: try:
yield self.fsm yield self.fsm
except automaton_errors.NotFound as e: except automaton_errors.NotFound as e:
@ -148,9 +146,6 @@ class BaseFilter(interface.FilterDriver):
{'filter': self, 'error': e}) {'filter': self, 'error': e})
self.reset() self.reset()
raise raise
finally:
LOG.debug('The PXE filter driver %s left the fsm_reset_on_error '
'context', self)
@locked_driver_event(Events.initialize) @locked_driver_event(Events.initialize)
def init_filter(self): def init_filter(self):
@ -177,7 +172,6 @@ class BaseFilter(interface.FilterDriver):
:param ironic: obligatory ironic client instance :param ironic: obligatory ironic client instance
:returns: nothing. :returns: nothing.
""" """
LOG.debug('Syncing the PXE filter driver %s', self)
def get_periodic_sync_task(self): def get_periodic_sync_task(self):
"""Get periodic sync task for the filter. """Get periodic sync task for the filter.

2
ironic_inspector/test/unit/test_pxe_filter.py
View File

@ -211,8 +211,6 @@ class TestBaseFilterInterface(BaseFilterBaseTest):
def test_sync(self): def test_sync(self):
self.driver.sync(self.mock_ironic) self.driver.sync(self.mock_ironic)
self.mock_log.debug.assert_called_once_with(
'Syncing the PXE filter driver %s', self.driver)
self.mock_reset.assert_not_called() self.mock_reset.assert_not_called()
def test_tear_down_filter(self): def test_tear_down_filter(self):

4
releasenotes/notes/remove_filter_logging-1a80419083c42bc6.yaml Normal file
View File

@ -0,0 +1,4 @@
---
fixes:
- Remove debug logging for PXE filter driver which tends to fill up
inspector logs when debug is enabled.