From a94486d80915ea3bede8ddecc51b9f99aa2faad7 Mon Sep 17 00:00:00 2001 From: Anton Arefiev Date: Tue, 23 Feb 2016 12:10:46 +0200 Subject: [PATCH] Remove downgrades from migrations According to cross project spec I622f89fe63327d44f9b229d3bd9e76e15acbaa7a downgrade migrations should be removed. Change-Id: Iee38d8ba5e414e67033db35db52724d3f9f84fd7 --- ironic_inspector/dbsync.py | 2 +- ironic_inspector/migrations/script.py.mako | 4 ---- .../migrations/versions/578f84f38d_inital_db_schema.py | 6 ------ .../migrations/versions/d588418040d_add_rules.py | 6 ------ .../e169a4a81d88_add_invert_field_to_rule_condition.py | 4 ---- .../notes/no-downgrade-migrations-514bf872d9f944ed.yaml | 5 +++++ 6 files changed, 6 insertions(+), 21 deletions(-) create mode 100644 releasenotes/notes/no-downgrade-migrations-514bf872d9f944ed.yaml diff --git a/ironic_inspector/dbsync.py b/ironic_inspector/dbsync.py index c075fde7e..3a021ff9b 100644 --- a/ironic_inspector/dbsync.py +++ b/ironic_inspector/dbsync.py @@ -39,7 +39,7 @@ def add_command_parsers(subparsers): parser = add_alembic_command(subparsers, name) parser.set_defaults(func=do_alembic_command) - for name in ['downgrade', 'stamp', 'show', 'edit']: + for name in ['stamp', 'show', 'edit']: parser = add_alembic_command(subparsers, name) parser.set_defaults(func=with_revision) parser.add_argument('--revision', nargs='?', required=True) diff --git a/ironic_inspector/migrations/script.py.mako b/ironic_inspector/migrations/script.py.mako index d45a32ae0..1c3fcb429 100644 --- a/ironic_inspector/migrations/script.py.mako +++ b/ironic_inspector/migrations/script.py.mako @@ -30,7 +30,3 @@ ${imports if imports else ""} def upgrade(): ${upgrades if upgrades else "pass"} - - -def downgrade(): - ${downgrades if downgrades else "pass"} diff --git a/ironic_inspector/migrations/versions/578f84f38d_inital_db_schema.py b/ironic_inspector/migrations/versions/578f84f38d_inital_db_schema.py index b0fa92ebb..ee052f7e2 100644 --- a/ironic_inspector/migrations/versions/578f84f38d_inital_db_schema.py +++ b/ironic_inspector/migrations/versions/578f84f38d_inital_db_schema.py @@ -61,9 +61,3 @@ def upgrade(): mysql_ENGINE='InnoDB', mysql_DEFAULT_CHARSET='UTF8' ) - - -def downgrade(): - op.drop_table('nodes') - op.drop_table('attributes') - op.drop_table('options') diff --git a/ironic_inspector/migrations/versions/d588418040d_add_rules.py b/ironic_inspector/migrations/versions/d588418040d_add_rules.py index 00ede8a5a..7b79704ab 100644 --- a/ironic_inspector/migrations/versions/d588418040d_add_rules.py +++ b/ironic_inspector/migrations/versions/d588418040d_add_rules.py @@ -62,9 +62,3 @@ def upgrade(): mysql_ENGINE='InnoDB', mysql_DEFAULT_CHARSET='UTF8' ) - - -def downgrade(): - op.drop_table('rules') - op.drop_table('rule_conditions') - op.drop_table('rule_actions') diff --git a/ironic_inspector/migrations/versions/e169a4a81d88_add_invert_field_to_rule_condition.py b/ironic_inspector/migrations/versions/e169a4a81d88_add_invert_field_to_rule_condition.py index dbe83ad42..001de0a7f 100644 --- a/ironic_inspector/migrations/versions/e169a4a81d88_add_invert_field_to_rule_condition.py +++ b/ironic_inspector/migrations/versions/e169a4a81d88_add_invert_field_to_rule_condition.py @@ -31,7 +31,3 @@ import sqlalchemy as sa def upgrade(): op.add_column('rule_conditions', sa.Column('invert', sa.Boolean(), nullable=True, default=False)) - - -def downgrade(): - op.drop_column('rule_conditions', 'invert') diff --git a/releasenotes/notes/no-downgrade-migrations-514bf872d9f944ed.yaml b/releasenotes/notes/no-downgrade-migrations-514bf872d9f944ed.yaml new file mode 100644 index 000000000..0a0db12e9 --- /dev/null +++ b/releasenotes/notes/no-downgrade-migrations-514bf872d9f944ed.yaml @@ -0,0 +1,5 @@ +--- +features: + - Database migrations downgrade was removed. More info about + database migration/rollback could be found here + http://docs.openstack.org/openstack-ops/content/ops_upgrades-roll-back.html