openstack/ironic-inspector
Code Issues Proposed changes

Stop configuring install_command in tox.

Browse Source 
Currently, we are overriding 'install_command' to use 'pip'. This is
considered poor behavior and 'python -m pip' should be used instead:

https://snarky.ca/why-you-should-use-python-m-pip/

It turns out that this is the the default value provided by tox:

https://tox.readthedocs.io/en/latest/config.html#conf-install_command

So we can remove the line and simply use the default value.

openstack-discuss thread
http://lists.openstack.org/pipermail/openstack-discuss/2020-April/014237.html

Bumping requirements and l-c with:
keystoneauth1 3.18.0
alembic 0.9.6
pika 0.10.0 (necessary for installation)
Change-Id: I849342bd077ab2f8bbda4e0a228c308eb7a4908b
This commit is contained in:
Iury Gregory Melo Ferreira 2020-04-17 19:57:26 +02:00
parent 721bd814a6
commit b9f1746643
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lower-constraints.txt
View File

@ -1,4 +1,4 @@
alembic==0.8.10 alembic==0.9.6
automaton==1.9.0 automaton==1.9.0
Babel==2.3.4 Babel==2.3.4
bandit==1.1.0 bandit==1.1.0
@ -14,7 +14,7 @@ hacking==3.0.0
ironic-lib==2.17.0 ironic-lib==2.17.0
jsonpath-rw==1.2.0 jsonpath-rw==1.2.0
jsonschema==2.6.0 jsonschema==2.6.0
keystoneauth1==3.14.0 keystoneauth1==3.18.0
keystonemiddleware==4.18.0 keystonemiddleware==4.18.0
mock==3.0.0 mock==3.0.0
netaddr==0.7.18 netaddr==0.7.18
@ -36,6 +36,7 @@ oslo.service==1.24.0
oslotest==3.2.0 oslotest==3.2.0
oslo.utils==3.33.0 oslo.utils==3.33.0
pbr==2.0.0 pbr==2.0.0
pika==0.10.0
pymemcache==1.2.9 pymemcache==1.2.9
pytz==2013.6 pytz==2013.6
reno==2.5.0 reno==2.5.0

4
requirements.txt
View File

@ -2,7 +2,7 @@
# of appearance. Changing the order has an impact on the overall integration # of appearance. Changing the order has an impact on the overall integration
# process, which may cause wedges in the gate later. # process, which may cause wedges in the gate later.
automaton>=1.9.0 # Apache-2.0 automaton>=1.9.0 # Apache-2.0
alembic>=0.8.10 # MIT alembic>=0.9.6 # MIT
construct>=2.9.39 # MIT construct>=2.9.39 # MIT
eventlet!=0.18.3,!=0.20.1,>=0.18.2 # MIT eventlet!=0.18.3,!=0.20.1,>=0.18.2 # MIT
Flask>=1.0 # BSD Flask>=1.0 # BSD
@ -10,7 +10,7 @@ futurist>=1.2.0 # Apache-2.0
ironic-lib>=2.17.0 # Apache-2.0 ironic-lib>=2.17.0 # Apache-2.0
jsonpath-rw<2.0,>=1.2.0 # Apache-2.0 jsonpath-rw<2.0,>=1.2.0 # Apache-2.0
jsonschema>=2.6.0 # MIT jsonschema>=2.6.0 # MIT
keystoneauth1>=3.14.0 # Apache-2.0 keystoneauth1>=3.18.0 # Apache-2.0
keystonemiddleware>=4.18.0 # Apache-2.0 keystonemiddleware>=4.18.0 # Apache-2.0
netaddr>=0.7.18 # BSD netaddr>=0.7.18 # BSD
pbr!=2.1.0,>=2.0.0 # Apache-2.0 pbr!=2.1.0,>=2.0.0 # Apache-2.0

1
tox.ini
View File

@ -6,7 +6,6 @@ ignore_basepython_conflict=true
[testenv] [testenv]
basepython = python3 basepython = python3
usedevelop = True usedevelop = True
install_command = pip install -U {opts} {packages}
deps = deps =
-c{env:UPPER_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master} -c{env:UPPER_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}
-r{toxinidir}/requirements.txt -r{toxinidir}/requirements.txt