openstack
/
ironic-inspector
Code Issues Proposed changes

Merge "Fix valid provision states for introspection"

This commit is contained in:
Jenkins 2017-03-17 19:07:18 +00:00 committed by Gerrit Code Review
parent 8f020342bc 490cad0b04
commit fec8c78600
2 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ironic_inspector/common/ironic.py
View File

@ -26,7 +26,7 @@ CONF = cfg.CONF
LOG = utils.getProcessingLogger(__name__)
# See http://specs.openstack.org/openstack/ironic-specs/specs/kilo/new-ironic-state-machine.html # noqa
VALID_STATES = {'enroll', 'manageable', 'inspecting', 'inspectfail'}
VALID_STATES = {'enroll', 'manageable', 'inspecting', 'inspect failed'}
SET_CREDENTIALS_VALID_STATES = {'enroll'}
# 1.11 is API version, which support 'enroll' state

11
releasenotes/notes/fix-wrong-provision-state-name-150c91c48d471bf9.yaml Normal file
View File

@ -0,0 +1,11 @@
---
fixes:
- |
Wrong provision state name 'inspectfail' in *ironic-inspector* valid
states for node inspection.
This issue leads to state inconsistency between *ironic* and
*ironic-inspector*. For example, if *ironic* inspection timeout is
lower than *ironic-inspector*'s, and inspection timeout occurs, *ironic*
will transition node into 'inspect failed' provision state. In such case
when node inspection finishes without errors the node will be in
'inspect failed' provision state with inspection in 'finished' state.