Commit Graph

1994 Commits (master)

Author SHA1 Message Date
Zuul 8cf0b3a9f8 Merge "[CI] Add sqlalchemy 2.0 unit testing" 2023-11-22 21:19:28 +00:00
Zuul 85aadd6338 Merge "Drop before_first_request usage of Flask app" 2023-11-22 09:59:16 +00:00
Pavlo Shchelokovskyy ad4664b9ac Drop before_first_request usage of Flask app
Flask 2.3 removed this method, with recommended way of running
startup actions explicitly as part of app initialization.

Change-Id: I5dea1320c9aa63c1ef1742382cb46ea7cc56b10b
2023-11-21 17:58:06 +00:00
Julia Kreger da6a4460a6 [CI] Add sqlalchemy 2.0 unit testing
Change-Id: I9a6ea8e18152ab9e2c26bfd68fa4129c01bc312f
2023-11-08 18:58:05 +00:00
Julia Kreger 24733d08bc SQLAlchemy 2.0 - Fix items lost in migration
Seems we forgot some leftovers of autocommit in our unit tests,
and we never updated our unit tests to the newer query style
for sqlalchemy 2.0.

This patch corrects those issues.

Change-Id: I9f3eb1f8efadd8438ac7dd69b06ea545b9a8ee5e
2023-11-08 10:55:27 -08:00
Zuul 11f52aa5d3 Merge "Fix python shebang" 2023-11-07 08:51:45 +00:00
Takashi Kajinami 1d2a6d7d32 Fix python shebang
The current shebang requires /usr/bin/python which is not available in
Ubuntu Jammy by default.

Change-Id: I7e8bff6da0a71216426985d3fa6fd5f30b853e2c
2023-10-17 16:02:33 +00:00
OpenStack Release Bot fbfe131c5d Update master for stable/2023.2
Add file to the reno documentation build to show release notes for

Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on

Sem-Ver: feature
Change-Id: Ice4a0d1b8e17d12f5b31aa0bcf4f0f8d76596510
2023-09-21 11:20:13 +00:00
Zuul f957f6fccc Merge "Support LLDP data coming in the new field" 2023-09-20 12:38:54 +00:00
Zuul f09ce1f01c Merge "Handle bracketed IPv6 redfish_address" 2023-09-20 10:57:34 +00:00
Zuul 728df8893d Merge "CI: re-add genade job to normal CI queues" 2023-09-20 00:11:53 +00:00
Zuul 04f0f5ba54 Merge "Fix bindep for debian bookworm for py3.11" 2023-09-19 22:31:55 +00:00
Julia Kreger a696dbee1f CI: re-add genade job to normal CI queues
We fixed the grenade job, it works now. Moving it back to the standard
check and gate queue.

Change-Id: Ie0e810c4eec1322180c024703b90a584f1161672
2023-09-19 14:36:58 -07:00
Jay Faulkner 31e07e423f Fix bindep for debian bookworm for py3.11
Debian Bookworm has mariadb, not mysql.

Change-Id: I1f1e620225dc280c4740600f53b7a78ace646882
2023-09-19 12:44:11 -07:00
Dmitry Tantsur be3d3772de Update the project status and move broken jobs to experimental
Since ironic-inspector is pending deprecation and does not see a lot of
changes, simply disable the jobs that do not pass. A release note is
issued about the status of the project.

Also: Re-adjust the memory footprint of the VMs since we use
tinycore linux on this job, *and* we were previously introsepcting
4 VMs at 1GB each. The count has been changed to two.

Change-Id: I11d10a9f83552b5875812fa65d87cc5c72081537
2023-09-19 08:03:43 -07:00
Harald Jensås 278ba52bf9
Handle bracketed IPv6 redfish_address
If redfish_address is in brackets, unwrap it
and check that it is a valid IPv6 address.
If that is the case use the unwrapped address
to avoid "Name or service not known".

Closes-Bug: #2036455
Change-Id: I0d194091be22e8401d379b7ffa720f8004cca3d0
2023-09-19 14:59:44 +02:00
Pierre Riteau 4a6bdaaf4b docs: fix typo
Change-Id: I9ad7b07834a0f83f82c2580fe277a337c6d03a12
2023-08-25 14:45:56 +02:00
likui 13a0d9374f tox: Remove basepython
Python 2 is EOL. No environment should be defaulting to it. Our CI
environments certainly aren't.

Change-Id: I7c5d73f8499a6eec3cae2a6254e6a26a64a9de9b
2023-08-02 16:58:22 +08:00
likui 53778d62f1 Add python3.10 support in testing runtime
In 2023.2 cycle testing runtime, project started adding python 3.10


Change-Id: I49200c48d2331cdeef9ceccb32e1f5b032d3c0ce
2023-07-31 15:25:30 +08:00
OpenStack Proposal Bot 62e42d3800 Imported Translations from Zanata
For more information about this automatic import see:

Change-Id: Idda5fcfacc300cb812827399b68c928a357e28fd
2023-05-09 04:01:21 +00:00
Zuul 418aa6b1f5 Merge "Upgrade to latest hacking - v6" 2023-04-25 14:37:29 +00:00
Dmitry Tantsur c2cb0f235a Support LLDP data coming in the new field
Change-Id: Id8d6978035f81215c52ed5ab3406d7adac2c561e
2023-04-25 12:22:33 +02:00
Jay Faulkner c3dd0f18ac Upgrade to latest hacking - v6
No code changes needed to work with latest flake8.

Change-Id: I5a45f31590534685016a4fdb78f3ea2b954150f1
2023-04-21 12:20:25 -07:00
Zuul 10ffd3a28e Merge "Update master for stable/2023.1" 2023-03-09 17:18:22 +00:00
Lon Hohberger 437e743e6c tests: Replace assertItemsEqual with assertCountEqual
The assertItemsEqual API is no longer current.

1. fd4abac1d6

Change-Id: I76aab9210de2a1871305d93afc80f1a0542b55f9
2023-03-09 10:23:04 -05:00
OpenStack Release Bot 974ec5a45e Update master for stable/2023.1
Add file to the reno documentation build to show release notes for

Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on

Sem-Ver: feature
Change-Id: I4e7efcbb18a2e44508ca7ca74250c9a17a3be4b6
2023-03-09 13:37:10 +00:00
Julia Kreger 836ba11b9b Use UTC for the timezone in functional tests
The prior code uses the local time zone, in my case
prsently 'PST' which pytz doesn't grok, however it does
grok UTC, and CI runs in UTC, and the API, as far as I know,
conveys in UTC. So this should just be for consistency.

Change-Id: Ia47b6adfc18be54f8e9623b34ef34b66436828dc
2023-02-21 08:38:26 -08:00
OpenStack Proposal Bot 933c4f8d10 Imported Translations from Zanata
For more information about this automatic import see:

Change-Id: Ia1b6c60ec3b3c649c223b1aa1bb2c21334940f74
2023-02-04 03:41:46 +00:00
Zuul d65d6020c2 Merge "Rename NodeInfo._lock to avoid conflict with Mock._lock in tests" 2023-01-27 13:12:40 +00:00
Zuul 21b02523a1 Merge "Stop gating on unit test coverage" 2023-01-26 16:51:50 +00:00
Zuul c43b7bf64b Merge "Use new get_rpc_client API from oslo.messaging" 2023-01-26 16:27:58 +00:00
Dmitry Tantsur 20797f0a82 Stop gating on unit test coverage
It's nice to keep coverage high, but with little active development
it starts merely hindering refactorings, causing us to gradually lower
the expected minimum anyway.

Change-Id: I4bec5dbb224c59048c24cf2189a80014d63bfa36
2023-01-26 16:17:42 +01:00
Jay Faulkner e1f3b71a39 Make reno ignore bugfix eol tags
Reno was assuming all tags ending in -eol represented an old, EOL'd
stable branch. That's not true for Ironic projects which have bugfix
branches. Update the regexp to exclude those branches.

Co-Authored-By: Adam McArthur <>
Change-Id: I2f8c80bd2aac2d00616ac2a2789a7da303d29656
2023-01-25 13:22:33 -08:00
Tobias Urdin 84b5f8cc1b Use new get_rpc_client API from oslo.messaging
Use the new API that is consistent with
the existing API instead of instantiating the client
class directly.

This was introduced in release 14.1.0 here [1] and
added into oslo.messaging here [2]


Change-Id: I66bef4d339b5ee2462dc46f626fd1b2c6182b2cd
2023-01-19 21:05:00 +00:00
Zuul a273c6fd07 Merge " Remove 'py_modules'" 2023-01-11 19:27:52 +00:00
Stephen Finucane f853061fe4 Remove 'py_modules'
This was merely obscuring a bug in pbr. setuptools doesn't do the
auto-discovery when pbr is in use. Remove it.

Also fixes the environments list where it is now validated for what is
installed by removing functional-py38, and fixing the job to just be

Signed-off-by: Stephen Finucane <>
Change-Id: Ife999840777f3c553f569d81cd826ef9d5a6765d
2023-01-11 08:22:52 -08:00
Dmitry Tantsur cb1e856b9f Rename NodeInfo._lock to avoid conflict with Mock._lock in tests
Starting with, Python's
Mock has its own _lock. I hope they rename it to something really
private (e.g. __lock), but for now rename our attribute (and hope that
no downstream plugins relied on it, sigh).

Change-Id: I7ba858fb3f259b8e7a3becde94b7ba6b90615287
2023-01-10 14:29:37 +01:00
Zuul c0f9602227 Merge "SQLAlchemy 2.0 Support" 2023-01-04 17:54:05 +00:00
Zuul 1069a7f3be Merge "Remove lib/neutron-legacy leftovers" 2023-01-03 20:45:52 +00:00
Riccardo Pittau 0f5bbf68d6 Fix tox4 and setuptools errors
- Remove skipsdist that it was never supported and causes breakage
when used with usedevelop.
- disable setuptools autodiscovery

Change-Id: Icd107c69be1685af9eddf9cc9fe2236d5eb57c5a
2022-12-28 15:42:45 +01:00
Sławek Kapłoński dac7f02d0a Remove lib/neutron-legacy leftovers
In [1] we finally got rid of the unfinished lib/neutron module and kept
only lib/neutron-legacy. It's renamed to lib/neutron now and it's the
only neutron related module in Devstack.
So this patch removes leftovers related to the old lib/neutron-legacy.


Change-Id: I698d87eba1fd92abfc4f631dc6109004d8bc827e
2022-12-20 11:19:31 +01:00
Anton Arefiev 3fe42b53fd SQLAlchemy 2.0 Support
Primarily remove the workaround added in
Ia6d512ff2ae417bab938cb095fbb0884d195010a which added
continued use of autocommit, which is incompatible with
SQLAlchemy 2.0.

Also set the environment for unit tests to report compatability
warnings, although it appears none are being reported at this time.

Also cuts out the db upgrade cruft to only use the online database
migration code through oslo_db's enginefacade, which has the smarts
to handle online or offline migrations.

And then, retools unit/functional test data storage to utlize sqlite,
and in that re-tooled the queries to prevent locking conditions
which could exist with queries, and some additional refactoring/cleanup.

Also, don't mock and test time.sleep().

Additionally, it looks like we have discovered the root cause of the
memory/connection leakage issue which has been observed, due to the
way lists of nodes are processed/returned.

This change was based upon the work in
I506da42a9891a245831f325e34bec92e0a3f33f0 which is included in
this commit as the entire database structure and interaction
has been modified for ironic-inspector.

Co-Authored-By: aarefiev <>
Story: 2009727
Task: 44132
Change-Id: Ic88eb9dec5fddc924a72d9a23c17a304954ebf46
2022-12-15 09:28:55 -08:00
Zuul 664aa3fb4c Merge "Update tox.ini for tox 4" 2022-12-14 16:40:53 +00:00
Julia Kreger 75e8c2ac50 [grenade] Explicitly enable Neutron ML2/OVS services in the CI job
As with [1] basic grenade job will be switched to run with OVN as
Neutron backend, which is default in Devstack, we need to explicitly
disable ML2/OVN neutron services in the grenade job and use
ML2/OVS related services in that job.



Change-Id: Ifc9923236c5971e1b63b15fb62506821c178926c
2022-12-13 13:38:48 -08:00
Riccardo Pittau be40022295 Update tox.ini for tox 4
Update tox.ini to be compatible with tox 4
It should also be retrocompatible with tox 3

Change-Id: I3625c77ddc28f6bb7f310be215ca347076762d90
2022-12-13 17:49:51 +01:00
Zuul d83454c3d0 Merge "Remove unicode literal from code" 2022-10-27 18:53:21 +00:00
LiZekun fe2abe1130 Remove unicode literal from code
All strings are considered as unicode literal string from Python 3.

This patch drops the explicit unicode literal (u'...')
appearances from the unicode strings.

Change-Id: I662c72686a7e0404da62fb677c666885ff5ac65a
2022-10-27 11:31:43 -07:00
OpenStack Proposal Bot d364e9dc30 Imported Translations from Zanata
For more information about this automatic import see:

Change-Id: Id1a044df75cfbc046a675988e8d1f00da78b928a
2022-10-12 03:16:15 +00:00
Pierre Riteau 3a249b60ba Add missing space to configuration help message
Change-Id: I9ffe108354515f2c80ee57cdeceeae9e5fa2d8b8
2022-10-04 18:22:44 +02:00
OpenStack Proposal Bot 18f64e91be Imported Translations from Zanata
For more information about this automatic import see:

Change-Id: Ibc04cf86e7d028e4253f4b47d22a58000b9cfed3
2022-09-24 02:13:37 +00:00