223 Commits

Author SHA1 Message Date
Kaifeng Wang
f37eb0fc58 Support ip6tables for iptables pxe filter
Adds a configuration option [iptables]ip_version to specify the
desired ip version for the iptables pxe filter, which can be set to
4 or 6. When set to 6, the iptables pxe filter will use ip6tables
command to manage rules for the port 547 which is the port of DHCPv6
server side.

The string type is used to make room for the future, when there is need
to automatically determine ip version from the binding interface.

Change-Id: I7de2be5950a23def3ec6490f2e6dfa3d5c42798a
Story: 1756012
Task: 11411
2018-11-07 09:53:47 +08:00
Zuul
10109622c1 Merge "Add introspection rules actions to add/remove traits on nodes" 2018-10-16 06:54:27 +00:00
Dmitry Tantsur
0a26a6677d Add introspection rules actions to add/remove traits on nodes
Otherwise it's not possible to modify them, since they're not updated
via the regular node updating mechanism.

Change-Id: I338015ff9dafe07f4e70a23ddcf6cd488eda9907
Story: #2003788
Task: #26496
2018-09-18 10:13:48 +02:00
OpenStack Proposal Bot
86d617374c Imported Translations from Zanata
For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html

Change-Id: If4490dcb193134c66d40679df9bcf09c06ca8d8d
2018-09-17 06:15:14 +00:00
OpenStack Proposal Bot
34b150340c Imported Translations from Zanata
For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html

Change-Id: I43f79db009797c1cabfd1208582e69741da68c83
2018-09-11 06:32:14 +00:00
OpenStack Proposal Bot
5b44f6e3e2 Imported Translations from Zanata
For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html

Change-Id: I6e08b5e6c68273ffdfaf81fa14f9de16c30029de
2018-09-09 06:17:38 +00:00
Harald Jensås
8c5d7de693 Add rootwrap filter for systemctl control of dnsmasq
The dnsmasq pxe filter takes start/stop commands for the
dnsmasq service as options. Restarting the systemd service
requries root access.

This change adds a rootwrap filter to allow systemctl
control of the dnsmasq service.

NOTE: The systemd service name is the one used in the RDO
distribution. Additional filters may be needed for other
distributions.

Story: 2002818
Task: 24754
Change-Id: Ie961ec4d3b6b65a462e2d2493f5b9240c2bfa7a6
2018-08-21 11:43:20 +02:00
Zuul
be06e77dab Merge "Remove deprecated option node_status_keep_time" 2018-08-13 18:59:12 +00:00
OpenStack Proposal Bot
d188c10791 Imported Translations from Zanata
For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html

Change-Id: I607f75188febeb630c4cd768b3d8fed68e9a8be8
2018-08-11 06:58:27 +00:00
Kaifeng Wang
0c7a52b624 Remove deprecated option node_status_keep_time
[DEFAULT]node_status_keep_time is deprecated long ago [1], this
patch removes it so that inspector will not automatically remove
node status in regards to configuration option.

This also make sense when we use other store backends in the
future.

Change-Id: I8261ce115fdb03ffcfe3a1cc4ca7c8ec747be832
Related-Bug: #1695858
2018-08-10 09:37:23 +08:00
e1d1d4e7a8 Update reno for stable/rocky
Change-Id: Iff77f1d7a218541c4f3ef187d01b1078a21ffc8f
2018-08-09 13:16:18 +00:00
Zuul
5bcbbc0224 Merge "Clean up pxe_filter related deprecations" 2018-08-06 15:31:11 +00:00
Zuul
0b8d6dd9b5 Merge "Allow nested action value formatting" 2018-08-06 13:39:14 +00:00
Kaifeng Wang
ec8eacdebf Clean up pxe_filter related deprecations
This removes deprecated [iptables]manage_firewall and code.
Other deprecation markers relate to [firewall] are removed as well.

Change-Id: I449e16975b05a331b08dd160e0dec4a7c3cf6734
Story: #1665666
Task: #11358
2018-08-06 13:42:01 +08:00
Kaifeng Wang
1ad6f69593 Stop introspection if set boot device failed
At the beginning of introspection, ironic inspector sets boot device and
reboot node through ironic, currently it only stops when reboot the node
is failed. Actually the node is not guaranteed to reboot with pxe in either
case.

This patch eliminates the descripency, so that if anything goes wrong, it
will be exposed early.

Change-Id: I416e42137e59e04f7fd282aa309f2f89cf574209
Story: #2002977
Task: #22985
2018-08-02 16:18:52 +08:00
Will Miller
0646970f58 Allow nested action value formatting
Modify introspection rules to allow formatting to be applied to strings
nested in dicts and lists in the actions.

Change-Id: Ia53e0de98438f7789e9b9136dcd85c1b1274b713
Story: #1670768
Task: #11362
2018-08-01 09:32:59 +01:00
Harald Jensås
c4abd6783b PXE Filter dnsmasq: manage macs not in ironic
This changes the dnsmasq PXE filter so that it keeps
macs that are no longer in ironic blacklisted unless
introspection is active or node_not_found_hook is set.

Replacing the previous behaviour that would
exclusively whitelist macs that are no longer in
ironic.

Story: 2001979
Task: 19589
Change-Id: Ib417089116dcbfb25f759708ee3cddcb88ae2111
2018-07-06 11:04:16 +00:00
Dmitry Tantsur
e7c3218f71 Add manage_boot parameter to introspection API
Adds a new node field "manage_boot" to store this value. When it is set
to False, neither boot device nor power state are touched for this node.
Instead, we expect a 3rd party to handle them.

We still manage the PXE filter because the node may need DHCP.

Change-Id: Id3585bd32138a069dfcfc0ab04ee4f5f10f0a5ea
Story: #1528920
Task: #11338
2018-06-25 12:09:17 +02:00
OpenStack Proposal Bot
c4821fd1d5 Imported Translations from Zanata
For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html

Change-Id: I37a4500ae9199a216e6fa1f1eba7fa161096d3e4
2018-06-19 07:39:50 +00:00
Mark Goddard
cdf79db9eb Update default Ironic API version to 1.38
Currently the default API version used when creating ironic client
objects is 1.19, which was from the Newton (6.1.0) release. While it is
possible to create a client object with a more recent version within
plugins, introspection rules always use the default. This prevents
access to and updating of fields added in versions after 1.19.

This change updates the default ironic API version to 1.38, which was
the version at the time of the most recent Queens series release
(10.1.0).

Change-Id: I395f18612e20d4f7d71e503391ca2381bad68192
Story: 2002166
Task: 20017
2018-06-08 10:15:58 +00:00
Zuul
81fd47a3fc Merge "PXE Filter dnsmasq: blacklist unknown host" 2018-05-08 04:05:57 +00:00
Harald Jensås
5e54e72136 PXE Filter dnsmasq: blacklist unknown host
Unless one or more nodes are on introspection and
node_not_found_hook is not set a dhcp_hostsdir ignore
record for wildcard mac '*:*:*:*:*:*' is maintained.

The iptables filter driver blocks DHCP requests on the
Inspector interface unless one or more nodes are on
introspection and node_not_found_hook is not set.

This change brings the dnsmasq filter driver to parity
by implementing logic similar to the iptables driver.

Related: rhbz#1574672
Story: 2001970
Task: 16864
Change-Id: Ibdd2210ecb3833a0d91205a7919122b7c0576b9e
2018-05-07 18:07:03 +02:00
OpenStack Proposal Bot
bded1ab3d2 Imported Translations from Zanata
For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html

Change-Id: I67f67c74b8ff7c1c33c489052ef836ea549bd7c4
2018-05-01 06:29:22 +00:00
Zuul
361fb091a5 Merge "Change the default discovery driver to fake-hardware" 2018-04-30 19:09:12 +00:00
Dmitry Tantsur
66f318b339 Change the default discovery driver to fake-hardware
The fake classic driver will be removed this release.

Depends-On: Ia0e95cbc1bb4dbd32793705b876ab8b474b753ad
Change-Id: I85f2a2a3ed1ca689c639c60e86853c821e808105
2018-04-30 14:36:34 +00:00
Zuul
c02a9f7c24 Merge "Support reload configuration on SIGHUP" 2018-04-28 10:51:18 +00:00
Zuul
f80f20818b Merge "Imported Translations from Zanata" 2018-04-23 17:11:49 +00:00
Kaifeng Wang
76898b7382 Support reload configuration on SIGHUP
This adds signal handler to reload mutable configuration options
on SIGHUP.

It has to be done manually, because ironic-inspector doesn't use
oslo.service.

Change-Id: I38955fe9dbfd339df2a10dcbb55e996bf515034a
Story: #1585595
Task: #12543
2018-04-17 16:33:16 +08:00
Zuul
6005a4ba5b Merge "Correct Queens release notes versions" 2018-04-11 18:47:31 +00:00
OpenStack Proposal Bot
5128a6396c Imported Translations from Zanata
For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html

Change-Id: If055e649e7d549885ea6f25003dfde94a01b5c0f
2018-03-29 06:29:42 +00:00
Dmitry Tantsur
e73ebb7ba0 Correct Queens release notes versions
We have released 7.2.0 for Queens, so the stable versions will be 7.2.x.

Change-Id: Ibcca81b8e7e23fccdede29846671865fa4bfe7c7
2018-03-01 16:12:17 +01:00
OpenStack Proposal Bot
0561fc6642 Imported Translations from Zanata
For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html

Change-Id: I7eac720d8d883fd87eea1c3d649e9e0acff3173d
2018-03-01 06:34:14 +00:00
OpenStack Proposal Bot
e9d9d638f2 Imported Translations from Zanata
For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html

Change-Id: I992282bd66ab0cb59f489c4138b2fadb3bb276a3
2018-02-18 07:29:18 +00:00
Zuul
3b9e4c0656 Merge "Retry port lists on failure in PXE filter periodic sync" 2018-02-15 00:40:57 +00:00
Dmitry Tantsur
3237511cc6 Retry port lists on failure in PXE filter periodic sync
These calls are subject to transient network problems, we should
not abort ironic-inspector process in this case. Also due to
bug 1748893 the port listing API can sometimes return HTTP 400.

This change retries port listing 5 times with 1 second break
before aborting the periodic task and thus the process.

This change introduces a dependency on the retrying library,
which is already widely used in OpenStack (including ironic).

Change-Id: I92fd70ca5692ce9f6798eedf9e540d5aa7c6f1af
Closes-Bug: #1748893
2018-02-14 15:10:39 +01:00
Zuul
84da941faf Merge "Only set switch_id in local_link_connection if it is a mac address" 2018-02-13 15:30:49 +00:00
Bob Fournier
97282c64e9 Only set switch_id in local_link_connection if it is a mac address
When the processed lldp data is used for setting the local_link_connection
switch_id, it will set it even if the Chassis ID is not a mac.  Need to
only set it when the ChassisId is a mac address, as is done when using
non-processed lldp data.  Ironic validates that switch_id is either a
mac address or OpenFlow datapath ID.

This fixes a regresssion introduced in Pike.

Change-Id: I566acb5b19852b541df7554870ab2666f7df9614
Closes-Bug: 1748022
2018-02-13 09:33:58 +00:00
Markos Chandras
fbeb0783e4 ironic_inspector: ironic: Fix 'auth_type' when 'auth_strategy' is used
We should override the 'auth_type' to 'none' when using the old way of
setting up authentication with 'auth_strategy' so we can override the
default 'auth_type' value before getting the session information.
This fixes the following issue

Unhandled error: MissingRequiredOptions: Auth plugin requires parameters which were not given: auth_url

This also adds a new testcase to test the strategy='noauth' scenario.

Closes-Bug: #1748263
Change-Id: I875e2b17f5c6829ad81f86c32959cb106bf57e53
2018-02-09 16:38:18 +02:00
76978212ea Update reno for stable/queens
Change-Id: I6f2a482b593e327fce4e222f534d429b143dadec
2018-02-07 15:26:40 -05:00
Zuul
13d74dd763 Merge "Remove sample policy and config files" 2018-02-07 11:45:06 +00:00
Jim Rollenhagen
5c54c0938e Remove sample policy and config files
Now we have docs, lets point people there rather than attempting to
maintain a copy in tree.

Also update the devstack plugin to build ironic.conf from scratch rather
than from the sample.

Change-Id: Id65a4f803832fefe467d59147c39d2dea604ed3c
2018-02-06 10:36:12 -08:00
OpenStack Proposal Bot
3bb1d36071 Imported Translations from Zanata
For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html

Change-Id: Icf7e08a2c092040f439fba2ba5783e9cefd2dde0
2018-02-06 06:19:37 +00:00
OpenStack Proposal Bot
2e8cfa5312 Imported Translations from Zanata
For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html

Change-Id: I95c73c947c02702b3e4ef5a9ac4ef69885aa1656
2018-02-05 06:23:20 +00:00
inspurericzhang
4aeeaf7397 fixed some "ironic" misspelling
Change-Id: I809d1709f3ab2f4690f856d780f720c65474849e
2018-02-02 11:27:13 +08:00
Zuul
0cf3316662 Merge "Add keystoneauth adapters" 2018-01-22 19:55:35 +00:00
OpenStack Proposal Bot
990021c8c0 Imported Translations from Zanata
For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html

Change-Id: I4e5e05a07369195c45feae48f15847ad06080e68
2018-01-17 06:10:43 +00:00
Pavlo Shchelokovskyy
918775cb01 Add keystoneauth adapters
Inspector sets API urls for ironic and swift from the config.
The better way would be to discovery them from the keystone
catalog.

Supporting this requires to register keystoneauth adapter
options to all config sections for service clients auth.
swiftclient still does not support adapter session client, so
pass all options from adapter explicitly.

New options were added 'service_type`, `service_name`, `region_name`
`endpoint_override`, `interfaces`.

Related-Bug: #1699547
Change-Id: I2e7ec02fdeeea21ef43136ddeabc98d499a8ba7f
Co-Authored-By: Anton Arefiev <aarefiev@mirantis.com>
2018-01-16 18:06:10 +00:00
John L. Villalovos
d7e1841680 Remove ironic_inspector/test/inspector_tempest_plugin/ directory
We now use the project openstack/ironic-tempest-plugin to store our
tempest plugin. All content from the
ironic_inspector/test/inspector_tempest_plugin/ directory has been
ported to that project.

We no longer want to have the plugin content stored here so we can
now delete it.

Change-Id: Ia8ea3a74d5aba1ea27eb6715c21667a30bac56b4
2018-01-05 12:52:54 -08:00
OpenStack Proposal Bot
84762ee111 Imported Translations from Zanata
For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html

Change-Id: Ia7dbef94937fac310e166485201300072ca7fcda
2017-12-24 06:41:36 +00:00
Zuul
8e1f3ede1c Merge "Terminal state transitions in transactions" 2017-12-22 19:04:46 +00:00