3237511cc6
These calls are subject to transient network problems, we should not abort ironic-inspector process in this case. Also due to bug 1748893 the port listing API can sometimes return HTTP 400. This change retries port listing 5 times with 1 second break before aborting the periodic task and thus the process. This change introduces a dependency on the retrying library, which is already widely used in OpenStack (including ironic). Change-Id: I92fd70ca5692ce9f6798eedf9e540d5aa7c6f1af Closes-Bug: #1748893
186 lines
7.6 KiB
Python
186 lines
7.6 KiB
Python
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
|
|
# implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
import socket
|
|
import unittest
|
|
|
|
from ironicclient import client
|
|
from ironicclient import exc as ironic_exc
|
|
import mock
|
|
from oslo_config import cfg
|
|
|
|
from ironic_inspector.common import ironic as ir_utils
|
|
from ironic_inspector.common import keystone
|
|
from ironic_inspector.test import base
|
|
from ironic_inspector import utils
|
|
|
|
|
|
CONF = cfg.CONF
|
|
|
|
|
|
class TestGetClientBase(object):
|
|
def test_get_client_with_auth_token(self, mock_client, mock_load,
|
|
mock_opts, mock_adapter):
|
|
fake_token = 'token'
|
|
fake_ironic_url = 'http://127.0.0.1:6385'
|
|
mock_sess = mock.Mock()
|
|
mock_adapter.return_value.get_endpoint.return_value = fake_ironic_url
|
|
mock_load.return_value = mock_sess
|
|
ir_utils.get_client(fake_token)
|
|
mock_adapter.assert_called_once_with(
|
|
'ironic', region_name='somewhere', session=mock_sess)
|
|
mock_adapter.return_value.get_endpoint.assert_called_once_with()
|
|
args = {'token': fake_token,
|
|
'os_ironic_api_version': ir_utils.DEFAULT_IRONIC_API_VERSION,
|
|
'max_retries': CONF.ironic.max_retries,
|
|
'retry_interval': CONF.ironic.retry_interval}
|
|
mock_client.assert_called_once_with(1, fake_ironic_url, **args)
|
|
|
|
def test_get_client_without_auth_token(self, mock_client, mock_load,
|
|
mock_opts, mock_adapter):
|
|
fake_ironic_url = 'http://127.0.0.1:6385'
|
|
mock_adapter.return_value.get_endpoint.return_value = fake_ironic_url
|
|
mock_sess = mock.Mock()
|
|
mock_load.return_value = mock_sess
|
|
ir_utils.get_client(None)
|
|
args = {'session': mock_sess,
|
|
'os_ironic_api_version': ir_utils.DEFAULT_IRONIC_API_VERSION,
|
|
'max_retries': CONF.ironic.max_retries,
|
|
'retry_interval': CONF.ironic.retry_interval}
|
|
mock_client.assert_called_once_with(1, fake_ironic_url, **args)
|
|
|
|
|
|
@mock.patch.object(keystone, 'get_adapter')
|
|
@mock.patch.object(keystone, 'register_auth_opts')
|
|
@mock.patch.object(keystone, 'get_session')
|
|
@mock.patch.object(client, 'Client')
|
|
class TestGetClientAuth(TestGetClientBase, base.BaseTest):
|
|
def setUp(self):
|
|
super(TestGetClientAuth, self).setUp()
|
|
ir_utils.reset_ironic_session()
|
|
self.cfg.config(auth_strategy='keystone')
|
|
self.cfg.config(os_region='somewhere', group='ironic')
|
|
self.addCleanup(ir_utils.reset_ironic_session)
|
|
|
|
|
|
@mock.patch.object(keystone, 'get_adapter')
|
|
@mock.patch.object(keystone, 'register_auth_opts')
|
|
@mock.patch.object(keystone, 'get_session')
|
|
@mock.patch.object(client, 'Client')
|
|
class TestGetClientNoAuth(TestGetClientBase, base.BaseTest):
|
|
def setUp(self):
|
|
super(TestGetClientNoAuth, self).setUp()
|
|
ir_utils.reset_ironic_session()
|
|
self.cfg.config(auth_strategy='noauth')
|
|
self.cfg.config(os_region='somewhere', group='ironic')
|
|
self.addCleanup(ir_utils.reset_ironic_session)
|
|
|
|
|
|
class TestGetIpmiAddress(base.BaseTest):
|
|
def test_ipv4_in_resolves(self):
|
|
node = mock.Mock(spec=['driver_info', 'uuid'],
|
|
driver_info={'ipmi_address': '192.168.1.1'})
|
|
ip = ir_utils.get_ipmi_address(node)
|
|
self.assertEqual('192.168.1.1', ip)
|
|
|
|
@mock.patch('socket.gethostbyname')
|
|
def test_good_hostname_resolves(self, mock_socket):
|
|
node = mock.Mock(spec=['driver_info', 'uuid'],
|
|
driver_info={'ipmi_address': 'www.example.com'})
|
|
mock_socket.return_value = '192.168.1.1'
|
|
ip = ir_utils.get_ipmi_address(node)
|
|
mock_socket.assert_called_once_with('www.example.com')
|
|
self.assertEqual('192.168.1.1', ip)
|
|
|
|
@mock.patch('socket.gethostbyname')
|
|
def test_bad_hostname_errors(self, mock_socket):
|
|
node = mock.Mock(spec=['driver_info', 'uuid'],
|
|
driver_info={'ipmi_address': 'meow'},
|
|
uuid='uuid1')
|
|
mock_socket.side_effect = socket.gaierror('Boom')
|
|
self.assertRaises(utils.Error, ir_utils.get_ipmi_address, node)
|
|
|
|
def test_additional_fields(self):
|
|
node = mock.Mock(spec=['driver_info', 'uuid'],
|
|
driver_info={'foo': '192.168.1.1'})
|
|
self.assertIsNone(ir_utils.get_ipmi_address(node))
|
|
|
|
self.cfg.config(ipmi_address_fields=['foo', 'bar', 'baz'])
|
|
ip = ir_utils.get_ipmi_address(node)
|
|
self.assertEqual('192.168.1.1', ip)
|
|
|
|
def test_ipmi_bridging_enabled(self):
|
|
node = mock.Mock(spec=['driver_info', 'uuid'],
|
|
driver_info={'ipmi_address': 'www.example.com',
|
|
'ipmi_bridging': 'single'})
|
|
self.assertIsNone(ir_utils.get_ipmi_address(node))
|
|
|
|
def test_loopback_address(self):
|
|
node = mock.Mock(spec=['driver_info', 'uuid'],
|
|
driver_info={'ipmi_address': '127.0.0.2'})
|
|
ip = ir_utils.get_ipmi_address(node)
|
|
self.assertIsNone(ip)
|
|
|
|
|
|
class TestCapabilities(unittest.TestCase):
|
|
|
|
def test_capabilities_to_dict(self):
|
|
capabilities = 'cat:meow,dog:wuff'
|
|
expected_output = {'cat': 'meow', 'dog': 'wuff'}
|
|
output = ir_utils.capabilities_to_dict(capabilities)
|
|
self.assertEqual(expected_output, output)
|
|
|
|
def test_dict_to_capabilities(self):
|
|
capabilities_dict = {'cat': 'meow', 'dog': 'wuff'}
|
|
output = ir_utils.dict_to_capabilities(capabilities_dict)
|
|
self.assertIn('cat:meow', output)
|
|
self.assertIn('dog:wuff', output)
|
|
|
|
|
|
class TestCallWithRetries(unittest.TestCase):
|
|
def setUp(self):
|
|
super(TestCallWithRetries, self).setUp()
|
|
self.call = mock.Mock(spec=[])
|
|
|
|
def test_no_retries_on_success(self):
|
|
result = ir_utils.call_with_retries(self.call, 'meow', answer=42)
|
|
self.assertEqual(result, self.call.return_value)
|
|
self.call.assert_called_once_with('meow', answer=42)
|
|
|
|
def test_no_retries_on_python_error(self):
|
|
self.call.side_effect = RuntimeError('boom')
|
|
self.assertRaisesRegexp(RuntimeError, 'boom',
|
|
ir_utils.call_with_retries,
|
|
self.call, 'meow', answer=42)
|
|
self.call.assert_called_once_with('meow', answer=42)
|
|
|
|
@mock.patch('time.sleep', lambda _x: None)
|
|
def test_retries_on_ironicclient_error(self):
|
|
self.call.side_effect = [
|
|
ironic_exc.ClientException('boom')
|
|
] * 3 + [mock.sentinel.result]
|
|
|
|
result = ir_utils.call_with_retries(self.call, 'meow', answer=42)
|
|
self.assertEqual(result, mock.sentinel.result)
|
|
self.call.assert_called_with('meow', answer=42)
|
|
self.assertEqual(4, self.call.call_count)
|
|
|
|
@mock.patch('time.sleep', lambda _x: None)
|
|
def test_retries_on_ironicclient_error_with_failure(self):
|
|
self.call.side_effect = ironic_exc.ClientException('boom')
|
|
self.assertRaisesRegexp(ironic_exc.ClientException, 'boom',
|
|
ir_utils.call_with_retries,
|
|
self.call, 'meow', answer=42)
|
|
self.call.assert_called_with('meow', answer=42)
|
|
self.assertEqual(5, self.call.call_count)
|