912c30830a
The edeploy plugin stores all of the facts it collects in the extra column of the Ironic db. When using real hardware, edeploy collects a large amount of facts and can lead to overflowing that column. This patch fixes this by storing the collected data in Swift instead. This makes it usable more generically as well. Anything stored on the 'data' key in the dictionary returned by the ramdisk is stored as a JSON encoded string in a Swift object. The object is named 'extra_hardware-<node uuid>' and is stored in the 'ironic-inspector' container. Change-Id: Ie9e017df735a95350991ce419fa3b64249819d70 Closes-Bug: 1461252
98 lines
4.1 KiB
Python
98 lines
4.1 KiB
Python
# Copyright 2013 Hewlett-Packard Development Company, L.P.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
# Mostly copied from ironic/tests/test_swift.py
|
|
|
|
import sys
|
|
|
|
try:
|
|
from unittest import mock
|
|
except ImportError:
|
|
import mock
|
|
from oslo_config import cfg
|
|
from six.moves import reload_module
|
|
from swiftclient import client as swift_client
|
|
from swiftclient import exceptions as swift_exception
|
|
|
|
from ironic_inspector.common import swift
|
|
from ironic_inspector.test import base
|
|
from ironic_inspector import utils
|
|
|
|
CONF = cfg.CONF
|
|
|
|
|
|
@mock.patch.object(swift_client, 'Connection', autospec=True)
|
|
class SwiftTestCase(base.BaseTest):
|
|
|
|
def setUp(self):
|
|
super(SwiftTestCase, self).setUp()
|
|
self.swift_exception = swift_exception.ClientException('', '')
|
|
|
|
CONF.set_override('username', 'swift', 'swift')
|
|
CONF.set_override('tenant_name', 'tenant', 'swift')
|
|
CONF.set_override('password', 'password', 'swift')
|
|
CONF.set_override('os_auth_url', 'http://authurl/v2.0', 'swift')
|
|
CONF.set_override('os_auth_version', '2', 'swift')
|
|
CONF.set_override('max_retries', 2, 'swift')
|
|
|
|
# The constructor of SwiftAPI accepts arguments whose
|
|
# default values are values of some config options above. So reload
|
|
# the module to make sure the required values are set.
|
|
reload_module(sys.modules['ironic_inspector.common.swift'])
|
|
|
|
def test___init__(self, connection_mock):
|
|
swift.SwiftAPI()
|
|
params = {'retries': 2,
|
|
'user': 'swift',
|
|
'tenant_name': 'tenant',
|
|
'key': 'password',
|
|
'authurl': 'http://authurl/v2.0',
|
|
'auth_version': '2'}
|
|
connection_mock.assert_called_once_with(**params)
|
|
|
|
def test_create_object(self, connection_mock):
|
|
swiftapi = swift.SwiftAPI()
|
|
connection_obj_mock = connection_mock.return_value
|
|
|
|
connection_obj_mock.put_object.return_value = 'object-uuid'
|
|
|
|
object_uuid = swiftapi.create_object('object', 'some-string-data')
|
|
|
|
connection_obj_mock.put_container.assert_called_once_with('ironic-'
|
|
'inspector')
|
|
connection_obj_mock.put_object.assert_called_once_with(
|
|
'ironic-inspector', 'object', 'some-string-data', headers=None)
|
|
self.assertEqual('object-uuid', object_uuid)
|
|
|
|
def test_create_object_create_container_fails(self, connection_mock):
|
|
swiftapi = swift.SwiftAPI()
|
|
connection_obj_mock = connection_mock.return_value
|
|
connection_obj_mock.put_container.side_effect = self.swift_exception
|
|
self.assertRaises(utils.Error, swiftapi.create_object, 'object',
|
|
'some-string-data')
|
|
connection_obj_mock.put_container.assert_called_once_with('ironic-'
|
|
'inspector')
|
|
self.assertFalse(connection_obj_mock.put_object.called)
|
|
|
|
def test_create_object_put_object_fails(self, connection_mock):
|
|
swiftapi = swift.SwiftAPI()
|
|
connection_obj_mock = connection_mock.return_value
|
|
connection_obj_mock.put_object.side_effect = self.swift_exception
|
|
self.assertRaises(utils.Error, swiftapi.create_object, 'object',
|
|
'some-string-data')
|
|
connection_obj_mock.put_container.assert_called_once_with('ironic-'
|
|
'inspector')
|
|
connection_obj_mock.put_object.assert_called_once_with(
|
|
'ironic-inspector', 'object', 'some-string-data', headers=None)
|