openstack
/
ironic-lib
Code Issues Proposed changes

Revert "Use dd conv=sparse when writing images to nodes" 

When using volumes, and having empty ones, the volumes are failing to
mount when using conv=sparse with dd . This is causing security
hardened volumes :
http://git.openstack.org/cgit/openstack/tripleo-image-elements/tree/elements/overcloud-secure/block-device-default.yaml

To fail when mounted via iscsi

This reverts commit ab0492a364.

Story: #2003755
Task: #26441
Change-Id: I03f53a50ada9aabe9e3fbb71106d5190ae110e01
This commit is contained in:
yolanda.robla 2018-09-13 15:51:50 +00:00 committed by Yolanda Robla
parent 65b3df1aa8
commit 3234f432e8
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
ironic_lib/disk_utils.py
View File

@ -315,8 +315,7 @@ def is_block_device(dev):
def dd(src, dst):
"""Execute dd from src to dst."""
utils.dd(src, dst, 'bs=%s' % CONF.disk_utils.dd_block_size, 'oflag=direct',
'conv=sparse')
utils.dd(src, dst, 'bs=%s' % CONF.disk_utils.dd_block_size, 'oflag=direct')
def qemu_img_info(path):