From 617056b2a36d039179271cb24fd6157ee2505ef5 Mon Sep 17 00:00:00 2001 From: Dmitry Tantsur Date: Wed, 29 May 2019 15:56:17 +0200 Subject: [PATCH] mdns: allow quoting in the [mdns]params configuration option Without quoting support it is not possible to use commas in the dict values. Commas are required for parameters like ipa_inspection_collectors. Change-Id: Id2bb06d461501048748feccee87ead4241a70179 --- ironic_lib/mdns.py | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/ironic_lib/mdns.py b/ironic_lib/mdns.py index 0dd2f87d..8560874c 100644 --- a/ironic_lib/mdns.py +++ b/ironic_lib/mdns.py @@ -21,6 +21,7 @@ import socket import time from oslo_config import cfg +from oslo_config import types as cfg_types from oslo_log import log as logging from six.moves.urllib import parse import zeroconf @@ -38,10 +39,12 @@ opts = [ cfg.IntOpt('lookup_attempts', min=1, default=3, help='Number of attempts to lookup a service.'), - cfg.DictOpt('params', - default={}, - help='Additional parameters to pass for the registered ' - 'service.'), + cfg.Opt('params', + # This is required for values that contain commas. + type=cfg_types.Dict(cfg_types.String(quotes=True)), + default={}, + help='Additional parameters to pass for the registered ' + 'service.'), ] CONF = cfg.CONF