zuul: Centralize irrelevant-files in legacy-ironic-lib-dsvm-base

Create a new base job: legacy-ironic-lib-dsvm-base

Define 'irrelevant-files' in legacy-ironic-lib-dsvm-base and remove
them from project.yaml. This means we only define 'irrelevant-files'
once. Also makes project.yaml much easier to read.

Fix the 'irrelevant-files' section to make sure we do test when
changes are made to 'requirements.txt'.

Sort the jobs lists in project.yaml.

Change-Id: I0534be1ff4ac4d3d2e40f282966683c7b60fc7ba

zuul.d/legacy-ironic-lib-jobs.yaml

@@ -1,27 +1,52 @@
+- job:
+    name: legacy-ironic-lib-dsvm-base
+    # NOTE: We do not use 'legacy-ironic-dsvm-base' as simpler and less
+    # confusing to define it all here and then use 'legacy-dsvm-base'
+    parent: legacy-dsvm-base
+    irrelevant-files:
+      - ^test-requirements.txt$
+      - ^.*\.rst$
+      - ^api-ref/.*$
+      - ^doc/.*$
+      - ^ironic_lib/tests/.*$
+      - ^releasenotes/.*$
+      - ^setup.cfg$
+      - ^tools/.*$
+      - ^tox.ini$
+    required-projects:
+      - openstack-infra/devstack-gate
+      - openstack/ironic
+      - openstack/ironic-lib
+      - openstack/ironic-python-agent
+      - openstack/pyghmi
+      - openstack/python-ironicclient
+      - openstack/tempest
+      - openstack/virtualbmc
+
 - job:
     name: ironic-lib-tempest-partition-agent_ipmitool
-    parent: legacy-ironic-dsvm-base
+    parent: legacy-ironic-lib-dsvm-base
     run: playbooks/legacy/ironic-lib-tempest-partition-agent_ipmitool/run.yaml
     post-run: playbooks/legacy/ironic-lib-tempest-partition-agent_ipmitool/post.yaml
     timeout: 5400
 
 - job:
     name: ironic-lib-tempest-partition-pxe_ipmitool
-    parent: legacy-ironic-dsvm-base
+    parent: legacy-ironic-lib-dsvm-base
     run: playbooks/legacy/ironic-lib-tempest-partition-pxe_ipmitool/run.yaml
     post-run: playbooks/legacy/ironic-lib-tempest-partition-pxe_ipmitool/post.yaml
     timeout: 5400
 
 - job:
     name: ironic-lib-tempest-wholedisk-agent_ipmitool
-    parent: legacy-ironic-dsvm-base
+    parent: legacy-ironic-lib-dsvm-base
     run: playbooks/legacy/ironic-lib-tempest-wholedisk-agent_ipmitool/run.yaml
     post-run: playbooks/legacy/ironic-lib-tempest-wholedisk-agent_ipmitool/post.yaml
     timeout: 5400
 
 - job:
     name: ironic-lib-tempest-wholedisk-pxe_ipmitool
-    parent: legacy-ironic-dsvm-base
+    parent: legacy-ironic-lib-dsvm-base
     run: playbooks/legacy/ironic-lib-tempest-wholedisk-pxe_ipmitool/run.yaml
     post-run: playbooks/legacy/ironic-lib-tempest-wholedisk-pxe_ipmitool/post.yaml
     timeout: 5400

zuul.d/project.yaml

@@ -2,93 +2,13 @@
     name: openstack/ironic-lib
     check:
       jobs:
-        - ironic-lib-tempest-wholedisk-agent_ipmitool:
-            irrelevant-files:
-              - ^(test-|)requirements.txt$
-              - ^.*\.rst$
-              - ^api-ref/.*$
-              - ^doc/.*$
-              - ^ironic_lib/tests/.*$
-              - ^releasenotes/.*$
-              - ^setup.cfg$
-              - ^tools/.*$
-              - ^tox.ini$
-        - ironic-lib-tempest-wholedisk-pxe_ipmitool:
-            irrelevant-files:
-              - ^(test-|)requirements.txt$
-              - ^.*\.rst$
-              - ^api-ref/.*$
-              - ^doc/.*$
-              - ^ironic_lib/tests/.*$
-              - ^releasenotes/.*$
-              - ^setup.cfg$
-              - ^tools/.*$
-              - ^tox.ini$
-        - ironic-lib-tempest-partition-agent_ipmitool:
-            irrelevant-files:
-              - ^(test-|)requirements.txt$
-              - ^.*\.rst$
-              - ^api-ref/.*$
-              - ^doc/.*$
-              - ^ironic_lib/tests/.*$
-              - ^releasenotes/.*$
-              - ^setup.cfg$
-              - ^tools/.*$
-              - ^tox.ini$
-        - ironic-lib-tempest-partition-pxe_ipmitool:
-            irrelevant-files:
-              - ^(test-|)requirements.txt$
-              - ^.*\.rst$
-              - ^api-ref/.*$
-              - ^doc/.*$
-              - ^ironic_lib/tests/.*$
-              - ^releasenotes/.*$
-              - ^setup.cfg$
-              - ^tools/.*$
-              - ^tox.ini$
+        - ironic-lib-tempest-partition-agent_ipmitool
+        - ironic-lib-tempest-partition-pxe_ipmitool
+        - ironic-lib-tempest-wholedisk-agent_ipmitool
+        - ironic-lib-tempest-wholedisk-pxe_ipmitool
     gate:
       jobs:
-        - ironic-lib-tempest-wholedisk-agent_ipmitool:
-            irrelevant-files:
-              - ^(test-|)requirements.txt$
-              - ^.*\.rst$
-              - ^api-ref/.*$
-              - ^doc/.*$
-              - ^ironic_lib/tests/.*$
-              - ^releasenotes/.*$
-              - ^setup.cfg$
-              - ^tools/.*$
-              - ^tox.ini$
-        - ironic-lib-tempest-partition-agent_ipmitool:
-            irrelevant-files:
-              - ^(test-|)requirements.txt$
-              - ^.*\.rst$
-              - ^api-ref/.*$
-              - ^doc/.*$
-              - ^ironic_lib/tests/.*$
-              - ^releasenotes/.*$
-              - ^setup.cfg$
-              - ^tools/.*$
-              - ^tox.ini$
-        - ironic-lib-tempest-wholedisk-pxe_ipmitool:
-            irrelevant-files:
-              - ^(test-|)requirements.txt$
-              - ^.*\.rst$
-              - ^api-ref/.*$
-              - ^doc/.*$
-              - ^ironic_lib/tests/.*$
-              - ^releasenotes/.*$
-              - ^setup.cfg$
-              - ^tools/.*$
-              - ^tox.ini$
-        - ironic-lib-tempest-partition-pxe_ipmitool:
-            irrelevant-files:
-              - ^(test-|)requirements.txt$
-              - ^.*\.rst$
-              - ^api-ref/.*$
-              - ^doc/.*$
-              - ^ironic_lib/tests/.*$
-              - ^releasenotes/.*$
-              - ^setup.cfg$
-              - ^tools/.*$
-              - ^tox.ini$
+        - ironic-lib-tempest-partition-agent_ipmitool
+        - ironic-lib-tempest-partition-pxe_ipmitool
+        - ironic-lib-tempest-wholedisk-agent_ipmitool
+        - ironic-lib-tempest-wholedisk-pxe_ipmitool