openstack
/
ironic-lib
Code Issues Proposed changes

Add raises note to disk_utils.get_disk_identifier 

get_disk_identifier can raise OSError when the underlying
method that is called, and hexdump is missing. Updating the
docstring to convey it appropriately.

Change-Id: Ia57bf10e40f89e095154b0d88d40b63d835de03a
Related-Bug: #1732470
This commit is contained in:
Julia Kreger 2017-11-15 17:20:18 -05:00
parent c5056c0f5d
commit fcf7bbb518
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
ironic_lib/disk_utils.py
View File

@ -140,6 +140,7 @@ def get_disk_identifier(dev):
http://www.syslinux.org/wiki/index.php/Comboot/chain.c32#mbr:
:param dev: Path for the already populated disk device.
:raises OSError: When the hexdump binary is unavailable.
:returns: The Disk Identifier.
"""
disk_identifier = utils.execute('hexdump', '-s', '440', '-n', '4',