According to Openstack summit session [1] stestr is maintained project
to which all Openstack projects should migrate.
Let's switch it then.
[1] https://etherpad.openstack.org/p/YVR-python-pti
Change-Id: Ibb1e23aceeb9a864306c52b410bda77736454ef0
Signed-off-by: Chuck Short <chucks@redhat.com>
hacking is not capped in g-r and it is in
blacklist for requirement as hacking new version
can break the gate jobs.
Hacking can break gate jobs because of various
reasons:
- There might be new rule addition in hacking
- Some rules becomes default from non-default
- Updates in pycodestyle etc
That was the main reason it was not added in g-r
auto sync also. Most of the project maintained the
compatible and cap the hacking version in
test-requirements.txt and update to new version when
project is ready. Bumping new version might need code
fix also on project side depends on what new in that
version.
If project does not have cap the hacking version then,
there is possibility of gate failure whenever new hacking
version is released by QA team.
Example of such failure in recent release of hacking 1.1.0
- http://lists.openstack.org/pipermail/openstack-dev/2018-May/130282.html
Change-Id: I2cdc79ed0cd302990a0434c477d6f3ec2c05fb8b
Fix the lower constraints settings to match the expected values.
We will manage the eventlet version using constraints now. See the
thread starting at
http://lists.openstack.org/pipermail/openstack-dev/2018-April/129096.html
for more details.
Change-Id: If7314a88a57bdd8db9bfa090e5e46c09c37a5087
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
Use latest version of flake8-import-order package, like we do in
openstack/ironic
Fix two issues detected by new version.
Change-Id: I3d2f5499f3a863167419469d313e06be79f51841
Enable the following off-by-default checks:
* [H106] Don't put vim configuration in source files.
* [H203] Use assertIs(Not)None to check for None.
* [H204] Use assert(Not)Equal to check for equality.
* [H205] Use assert(Greater|Less)(Equal) for comparison.
* [H210] Require ‘autospec’, ‘spec’, or ‘spec_set’ in
mock.patch/mock.patch.object calls
* [H904] Delay string interpolations at logging calls.
Fix code that failed [H904]. Nothing else failed the new added checks.
Change-Id: I727c944aad04298de07bcdd1d0008dcb9ffe32e9
Since pbr already landed and the old version of hacking seems not
work very well with pbr>=2, we should update it to match global
requirement.
Partial-Bug: #1668848
Change-Id: Icb9a79cac0222db5261e8802b4b3b08c4d5e6ac2
Use the flake8 plugin flake8-import-order to check import ordering. It
can do it automatically and don't need reviewers to check it.
Change-Id: Ib3fde54d8baa2c6e3567ff3f1a902de4b25f9f70
Hacking's latest release is 0.11.0. Most other ironic projects are using
this release.
These updates are done project-by-project to avoid introducing
unexpected new hacking rules to projects. This version bump already
applies cleanly to ironic-lib with no code style changes.
Change-Id: I6e47390299bf8f073b8c8413f0cd4e1365f938bb
This patch fixes all sphinx warnings generated by malformed docstrings.
Additionally, it contains formatting and accuracy fixes for the metrics
docstrings, to ensure blockquotes are properly rendered, and to indicate
the get_metrics_logger() method is actually in metrics_utils.
Finally, this adds doc8 to the pep8 job, ensuring we don't reintroduce
some of these errors. As a note, there are items that can cause warnings
in doc builds that aren't enforced by doc8, and can't be enforced until
a doc build job is added to project-config.
Change-Id: I622812bfe8af576ab215c098dd211c6faf697a0c
Partial-bug: #1614272
Partial-bug: #1611559
This adds a doc build for ironic-lib. Currently the only documentation
is that generated from docstrings.
Change-Id: I6ee00ad863bc7ce72958db4e8d5b6871a5b96eb0
Partial-bug: #1614272
The eventlet library is used in testing. Move it to
test-requirements.txt.
The greenlet library is not directly used. Remove it from
requirements.txt.
Make it more explicit which tests need the eventlet mock.
Change-Id: I117ec6a2ee4bb1a52e6de088cd1ddd5b0cce5efe
This moves the tests directory under ironic_lib, which is kind of the
standard around here. Updates tox.ini to point at this directory.
Also updates tox.ini to use ostestr, to be more standard with other
OpenStack things.
Change-Id: I91e6ba38c44a475602175b66c10757ec11b173f9