Update patch set 2

Patch Set 2: Code-Review-1

(2 comments)

Patch-set: 2
Reviewer: Gerrit User 10239 <10239@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
Attention: {"person_ident":"Gerrit User 15519 \u003c15519@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"Dmitry Tantsur replied on the change"}
This commit is contained in:
Gerrit User 10239 2022-04-04 09:57:06 +00:00 committed by Gerrit Code Review
parent 02c52e7180
commit 8c5eb426cd
1 changed files with 34 additions and 0 deletions

View File

@ -16,6 +16,40 @@
"message": "recheck",
"revId": "68c044d9b0e6c323cf94eb8f9d4837369bd60415",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "94df0c40_f76756de",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 10239
},
"writtenOn": "2022-04-04T09:57:06Z",
"side": 1,
"message": "We\u0027re going to break TripleO if we just copy the element with the same name: https://opendev.org/openstack/tripleo-image-elements/src/branch/master/elements/ironic-agent-multipath.\n\nNothing in the element seems to be ironic-agent specific, right? Maybe just call it \"iscsi-multipath\" or something like that? It could even go to DIB itself, but I understand that it will take time.",
"revId": "68c044d9b0e6c323cf94eb8f9d4837369bd60415",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "7114406a_1d9e0fe3",
"filename": "dib/ironic-agent-multipath/element-deps",
"patchSetId": 2
},
"lineNbr": 3,
"author": {
"id": 10239
},
"writtenOn": "2022-04-04T09:57:06Z",
"side": 1,
"message": "Is this really needed? I don\u0027t think so.",
"revId": "68c044d9b0e6c323cf94eb8f9d4837369bd60415",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}