From bca26200102cb1da12e66b01904cc5e2c082df82 Mon Sep 17 00:00:00 2001 From: Mark Goddard Date: Mon, 27 Jun 2022 10:25:15 +0100 Subject: [PATCH] Add smartmontools package to DIB image This package includes smartctl, which is necessary for ATA secure erase disk cleaning. Without this package, IPA will fall back to shredding ATA devices, and you will lose hours of your life. Worse, until https://review.opendev.org/c/openstack/ironic-python-agent/+/847591, the lack of smartctl was silently ignored. Change-Id: I6952b833e0be4a47e45e9c4d4459956093628b6a (cherry picked from commit 57f50f7e10e0043d7aa1e860b72f98211eef4567) --- dib/ironic-python-agent-ramdisk/package-installs.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dib/ironic-python-agent-ramdisk/package-installs.yaml b/dib/ironic-python-agent-ramdisk/package-installs.yaml index fe88b60..1423d60 100644 --- a/dib/ironic-python-agent-ramdisk/package-installs.yaml +++ b/dib/ironic-python-agent-ramdisk/package-installs.yaml @@ -27,6 +27,8 @@ e2fsprogs: nvme-cli: # This provides iscsistart which is required for iBFT support open-iscsi: +# smartctl is required for ATA secure erase. +smartmontools: libffi-dev: build-only: true