openstack
/
ironic-python-agent-builder
Code Issues Proposed changes

dhcp-all-interfaces: let NetworkManager doit. 

Override the default for DIB_DHCP_NETWORK_MANAGER_AUTO
to `true` on RHEL and CentOS release 8 and later.

The dhcp-all-interfaces element is configured to only
apply NetworkManager configuration. The service:
dhcp-all-interfaces will not be enabled. Not enabling the
service allows NetworkManager to do the interface auto-
configuration. In release 8 and later it should do this
just as good, or even better, compared to the
dhcp-all-interfaces.sh script.

Depends-On: Id6f8d6aaaf52a78175bb6c065ec88274c364834e
Change-Id: I12950733bfe54cae62d299b4c5987449d551857a
(cherry picked from commit bdb387bb84)
This commit is contained in:
Harald Jensås 2022-01-23 23:49:21 +01:00 committed by Julia Kreger
parent faef1050d5
commit e8b5115089
2 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
dib/ironic-python-agent-ramdisk/environment.d/20-ipa-distro-family.bash
View File

@ -5,6 +5,10 @@ else
export IPA_DISTRO_FAMILY=other
fi
if [[ ${DISTRO_NAME} =~ (centos|rhel) && ${DIB_RELEASE%-stream} > 7 ]]; then
export DIB_DHCP_NETWORK_MANAGER_AUTO=${DIB_DHCP_NETWORK_MANAGER_AUTO:-true}
fi
# NOTE(rpittau) force Python version to 3 for debian
if [[ $DISTRO_NAME =~ debian ]]; then
DIB_PYTHON_VERSION=3

14
releasenotes/notes/network-manager-auto-dhcp-all-interfaces-rhel-centos-relese-gt-7-0c2054d0067c6e93.yaml Normal file
View File

@ -0,0 +1,14 @@
---
other:
- |
On RHEL and CentOS 8 and later the *dhcp-all-interfaces* diskimage-builder
element is now configured to only apply NetworkManager configuration by
default. The *dhcp-all-interfaces* service will not be enabled.
To re-enable the *dhcp-all-interfaces* service, set
``DIB_DHCP_NETWORK_MANAGER_AUTO=false`` in the environment.
NetworkManager is quite capable to do automatic interface configuration.
NetworkManager will by default try to auto-configure any interface with
no configuration, it will use DHCP for IPv4 and Router Advertisements to
decide how to initialize IPv6.