openstack
/
ironic-python-agent
Code Issues Proposed changes

Merge "Remove unused version parameter in version header function"

This commit is contained in:
Zuul 2020-04-09 15:52:29 +00:00 committed by Gerrit Code Review
parent 83b5a8b202 9ac6040110
commit 020761a513
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
ironic_python_agent/ironic_api_client.py
View File

@ -78,7 +78,7 @@ class APIClient(object):
cert=cert, cert=cert,
**kwargs) **kwargs)
def _get_ironic_api_version_header(self, version=MIN_IRONIC_VERSION): def _get_ironic_api_version_header(self):
# TODO(TheJulia): It would be great to improve version handling # TODO(TheJulia): It would be great to improve version handling
# logic, but we need to ship a newer version if we can. # logic, but we need to ship a newer version if we can.
ironic_version = "%d.%d" % self._get_ironic_api_version() ironic_version = "%d.%d" % self._get_ironic_api_version()
@ -117,10 +117,8 @@ class APIClient(object):
if api_ver >= AGENT_VERSION_IRONIC_VERSION: if api_ver >= AGENT_VERSION_IRONIC_VERSION:
data['agent_version'] = version.version_info.release_string() data['agent_version'] = version.version_info.release_string()
headers = self._get_ironic_api_version_header(
AGENT_VERSION_IRONIC_VERSION) headers = self._get_ironic_api_version_header()
else:
headers = self._get_ironic_api_version_header()
try: try:
response = self._request('POST', path, data=data, headers=headers) response = self._request('POST', path, data=data, headers=headers)