openstack/ironic-python-agent
Code Issues Proposed changes

update api tests to validate command results

Browse Source
This commit is contained in:
Russell Haering 2013-12-27 15:07:24 -08:00
parent 667902eada
commit 047a417110
1 changed files with 5 additions and 3 deletions

8
teeth_agent/tests/api.py

@ -57,10 +57,12 @@ class TestTeethAPI(unittest.TestCase):
self.assertEqual(data['version'], status.version)
def test_execute_agent_command_success(self):
result = {'test': 'result'}
mock_agent = mock.MagicMock()
mock_agent.execute_command.return_value = result
api_server = api.TeethAgentAPIServer(mock_agent)
valid_command = {
command = {
'name': 'do_things',
'params': {'key': 'value'},
}
@ -68,7 +70,7 @@ class TestTeethAPI(unittest.TestCase):
response = self._make_request(api_server,
'POST',
'/v1.0/command',
data=valid_command)
data=command)
self.assertEqual(mock_agent.execute_command.call_count, 1)
args, kwargs = mock_agent.execute_command.call_args
@ -76,7 +78,7 @@ class TestTeethAPI(unittest.TestCase):
self.assertEqual(kwargs, {'key': 'value'})
self.assertEqual(response.status_code, 200)
data = json.loads(response.data)
self.assertEqual(data, {'result': 'success'})
self.assertEqual(data, {'command': command, 'result': result})
def test_execute_agent_command_validation(self):
mock_agent = mock.MagicMock()