openstack/ironic-python-agent
Code Issues Proposed changes

Fix wrong result of filter_device in the base interface

Browse Source 
Returning None means "exclude any device". It still works if the only
hardware manager is GenericHardwareManager, but enabling any more
without overriding filter_device causes all devices to get filtered.

Change-Id: I25eb028baa1b9182caee07a0b935e9fa107999a8
Closes-Bug: #2117234
Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
This commit is contained in:
Dmitry Tantsur
2025-07-21 13:49:03 +02:00
parent 780cf3615d
commit 0ad2685ce4
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
ironic_python_agent/hardware.py
View File

@@ -1374,6 +1374,7 @@ class HardwareManager(object, metaclass=abc.ABCMeta):
other hardware managers. other hardware managers.
:return: The modified device or None to exclude it. :return: The modified device or None to exclude it.
""" """
raise errors.IncompatibleHardwareMethodError()
class GenericHardwareManager(HardwareManager): class GenericHardwareManager(HardwareManager):