openstack
/
ironic-python-agent
Code Issues Proposed changes

Remove duplicated test for caching image 

The test test_cache_image_success is (bad) duplicate of the
test test_cache_image

The test is trying to retrieve a real url and saving it into
a block device. Mock several calls to avoid this behavior and
and assert that the cached image is properly saved.

Change-Id: Ie2ff5931cc77e5cdd1621c652d73a62fed0b69a6
Partial-Bug: #1326849
This commit is contained in:
Ghe Rivero 2014-06-11 00:51:11 +02:00
parent 263f97c0e0
commit 0ee229eb80
1 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
ironic_python_agent/tests/extensions/standby.py
View File

@ -83,12 +83,6 @@ class TestStandbyExtension(test_base.BaseTestCase):
standby._validate_image_info,
invalid_info)
def test_cache_image_success(self):
result = self.agent_extension.cache_image(
'cache_image',
image_info=self._build_fake_image_info())
result.join()
def test_cache_image_invalid_image_list(self):
self.assertRaises(errors.InvalidCommandParamsError,
self.agent_extension.cache_image,