openstack
/
ironic-python-agent
Code Issues Proposed changes

Update patch set 36 

Patch Set 36: Backport-Candidate-1 Code-Review+2 Workflow+1

(2 comments)

Patch-set: 36
Reviewer: Gerrit User 10342 <10342@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+2, 8b6552fab19cd77819452e0ebdd89fec34b32a4f
Label: Workflow=+1, a66312770e2353e93d445e08a91baa6c51a10499
Label: Backport-Candidate=-1, 21145c049bc93deeedeec2e3de517050b1030f0e
Attention: {"person_ident":"Gerrit User 10342 \u003c10342@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_10342\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 11655 \u003c11655@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_10342\u003e replied on the change"}
This commit is contained in:
Gerrit User 10342 2023-01-31 17:50:31 +00:00 committed by Gerrit Code Review
parent 0a1df390c6
commit 1d51201b7d
2 changed files with 35 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
2c7f95e3ace162118ef3249cdfedb60a7dc2d652
View File

@ -51,6 +51,23 @@
"message": "LGTM.",
"revId": "2c7f95e3ace162118ef3249cdfedb60a7dc2d652",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "57ba3415_26f7b7e5",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 36
},
"lineNbr": 0,
"author": {
"id": 10342
},
"writtenOn": "2023-01-31T17:50:31Z",
"side": 1,
"message": "It is a *MUST* that a docs patch come in as a follow up to this. ",
"revId": "2c7f95e3ace162118ef3249cdfedb60a7dc2d652",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

18
fbde381271bc43f1c17eeb65cb410e1a4165c296
View File

@ -69,6 +69,24 @@
"revId": "fbde381271bc43f1c17eeb65cb410e1a4165c296",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "45aee259_3af3b294",
"filename": "ironic_python_agent/hardware_managers/mlnx.py",
"patchSetId": 34
},
"lineNbr": 156,
"author": {
"id": 10342
},
"writtenOn": "2023-01-31T17:50:31Z",
"side": 1,
"message": "Yes, this is a requirement. Please do this in a follow up.",
"parentUuid": "5cd6dd70_3388f92f",
"revId": "fbde381271bc43f1c17eeb65cb410e1a4165c296",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {