openstack/ironic-python-agent
Code Issues Proposed changes

Reduce logging verbosity when collecting logs

Browse Source 
It's not uncommon that some commands fail when collecting logs.
We already log all failures in utils.execute, no need to duplicate
them with a non-fatal ERROR logging.

Change-Id: If151b3a3be979bd2b3ce01030e5d6242ad74eaa3
This commit is contained in:
Dmitry Tantsur 2021-06-11 16:04:59 +02:00
parent 2fab70c36b
commit 2fcf35e56d
1 changed files with 1 additions and 2 deletions

3
ironic_python_agent/utils.py

@ -478,7 +478,6 @@ def get_command_output(command):
except (processutils.ProcessExecutionError, OSError) as e: except (processutils.ProcessExecutionError, OSError) as e:
error_msg = ('Failed to get the output of the command "%(command)s". ' error_msg = ('Failed to get the output of the command "%(command)s". '
'Error: %(error)s' % {'command': command, 'error': e}) 'Error: %(error)s' % {'command': command, 'error': e})
LOG.error(error_msg)
raise errors.CommandExecutionError(error_msg) raise errors.CommandExecutionError(error_msg)
return io.BytesIO(out) return io.BytesIO(out)
@ -547,7 +546,7 @@ def collect_system_logs(journald_max_lines=None):
try: try:
io_dict[file_name] = get_command_output(command) io_dict[file_name] = get_command_output(command)
except errors.CommandExecutionError: except errors.CommandExecutionError:
pass LOG.debug('Collecting logs from command %s has failed', command)
io_dict = {} io_dict = {}
file_list = [] file_list = []