openstack
/
ironic-python-agent
Code Issues Proposed changes

Update patch set 4 

Patch Set 4: Code-Review-1

(1 comment)

Patch-set: 4
Reviewer: Gerrit User 10239 <10239@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, 181b28e7e4c8cb0c4229bd7036ea0ff9c8a8ebde
This commit is contained in:
Gerrit User 10239 2023-04-17 15:00:57 +00:00 committed by Gerrit Code Review
parent fcad0041c9
commit 34eac0c6bf
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
30b360d5438b85d43356ede831284b33b9dd172b Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "8d8fbb18_e3c90fb0",
"filename": "ironic_python_agent/netutils.py",
"patchSetId": 4
},
"lineNbr": 215,
"author": {
"id": 10239
},
"writtenOn": "2023-04-17T15:00:57Z",
"side": 1,
"message": "As discussed on IRC, the list of interfaces and their addresses can be obtained from psutil which we already use for other purposes: https://paste.opendev.org/show/b2ocscuZRaG99nymD9PB/",
"revId": "30b360d5438b85d43356ede831284b33b9dd172b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}