openstack
/
ironic-python-agent
Code Issues Proposed changes

Update patch set 5 

Patch Set 5: Code-Review+1

(1 comment)

Patch-set: 5
Reviewer: Gerrit User 10342 <10342@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+1, e6013dc9daf6c39008c02db971b08caddb6a9ed6
Attention: {"person_ident":"Gerrit User 11655 \u003c11655@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_10342\u003e replied on the change"}
This commit is contained in:
Gerrit User 10342 2023-04-17 22:13:19 +00:00 committed by Gerrit Code Review
parent 80a0552cb6
commit 380be888c4
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
76accfb880474445a5dcb07825889123b3dd0237 Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "1b934400_17f20361",
"filename": "ironic_python_agent/efi_utils.py",
"patchSetId": 5
},
"lineNbr": 286,
"author": {
"id": 10342
},
"writtenOn": "2023-04-17T22:13:19Z",
"side": 1,
"message": "Hmm. If we are ignoring errors, are we guaranteed cmd_output is not-None here?",
"revId": "76accfb880474445a5dcb07825889123b3dd0237",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}